Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Unified Diff: scripts/slave/runtest.py

Issue 217053012: Make results_dashboard send just one request per test run. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Group results into lists of limited length. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/runtest.py
diff --git a/scripts/slave/runtest.py b/scripts/slave/runtest.py
index cf3cd289cf8e1f0689242f51006bd6a1927ce652..5f6e908c0c7b30b275260115a755cff25e223a99 100755
--- a/scripts/slave/runtest.py
+++ b/scripts/slave/runtest.py
@@ -574,10 +574,6 @@ def _SendResultsToDashboard(results_tracker, system, test, url, build_dir,
supplemental_columns_file, extra_columns=None):
"""Sends results from a results tracker (aka log parser) to the dashboard.
- TODO(qyearsley): Change this function and results_dashboard.SendResults so
- that only one request is made per test run (instead of one per graph name).
- Also, maybe refactor this function to take fewer arguments.
-
Args:
results_tracker: An instance of a log parser class, which has been used to
process the test output, so it contains the test results.
@@ -601,14 +597,11 @@ def _SendResultsToDashboard(results_tracker, system, test, url, build_dir,
supplemental_columns_file)
if extra_columns:
supplemental_columns.update(extra_columns)
- for logname, log in results_tracker.PerformanceLogs().iteritems():
- lines = [str(l).rstrip() for l in log]
- try:
- results_dashboard.SendResults(logname, lines, system, test, url,
- mastername, buildername, buildnumber,
- build_dir, supplemental_columns)
- except NotImplementedError as e:
- print 'Did not submit to results dashboard: %s' % e
+
+ logs_dict = results_tracker.PerformanceLogs()
+ results_dashboard.SendResults(logs_dict, system, test, url, mastername,
+ buildername, buildername, buildnumber,
+ build_dir, supplemental_columns)
def _BuildCoverageGtestExclusions(options, args):

Powered by Google App Engine
This is Rietveld 408576698