Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 217053010: Revert of Rename PrivateMode enum values: (Closed)

Created:
6 years, 8 months ago by Ryan Hamilton
Modified:
6 years, 8 months ago
Reviewers:
mef, Nicolas Zea
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Revert of Rename PrivateMode enum values: (https://codereview.chromium.org/215023002/) Reason for revert: Broke build. http://build.chromium.org/p/chromium.linux/builders/Linux%20Builder%20%28dbg%29/builds/71042/steps/compile/logs/stdio#error1 Original issue's description: > Rename PrivateMode enum values: > > kPrivacyModeDisabled => PRIVACY_MODE_DISABLED > kPrivacyModeEnabled => PRIVACY_MODE_ENABLED > > To match the chromium style guide: > > Though the Google C++ Style Guide now says to use kConstantNaming for enums, > Chromium was written using MACRO_STYLE naming. Continue to use this style for consistency. > > R=mef@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260281 TBR=mef@chromium.org,zea@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260296

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -95 lines) Patch
M chrome/browser/net/preconnect.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gcm/engine/connection_factory_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M jingle/glue/proxy_resolving_client_socket.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/base/privacy_mode.h View 1 chunk +3 lines, -2 lines 0 comments Download
M net/http/disk_cache_based_quic_server_info_unittest.cc View 5 chunks +5 lines, -7 lines 0 comments Download
M net/http/http_network_transaction.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_network_transaction_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M net/http/http_proxy_client_socket_pool.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/http/http_proxy_client_socket_pool_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_request_info.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_stream_factory_impl_job.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/http/http_stream_factory_impl_unittest.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M net/quic/crypto/quic_crypto_client_config_test.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/quic_client_session_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_crypto_client_stream_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/quic_crypto_server_stream_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_http_stream_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_session_key.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_session_key_test.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M net/quic/quic_stream_factory_test.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M net/quic/test_tools/crypto_test_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/client_socket_pool_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/socket/ssl_client_socket_pool.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/ssl_client_socket_pool_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M net/socket_stream/socket_stream.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/spdy/spdy_http_stream_unittest.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M net/spdy/spdy_network_transaction_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/spdy/spdy_proxy_client_socket_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_session_key.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_session_pool.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_session_pool_unittest.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M net/spdy/spdy_session_unittest.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M net/spdy/spdy_stream_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_websocket_stream_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/end_to_end_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/tools/quic/quic_client_bin.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_client_session_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_spdy_client_stream_test.cc View 1 chunk +1 line, -2 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_request_http_job.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/websockets/websocket_job.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/websockets/websocket_job_test.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Ryan Hamilton
Created Revert of Rename PrivateMode enum values:
6 years, 8 months ago (2014-03-28 22:08:27 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/217053010/1
6 years, 8 months ago (2014-03-28 22:09:07 UTC) #2
commit-bot: I haz the power
6 years, 8 months ago (2014-03-28 22:12:51 UTC) #3
Message was sent while issue was closed.
Change committed as 260296

Powered by Google App Engine
This is Rietveld 408576698