Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: Source/core/html/HTMLMediaElement.idl

Issue 217053009: Validate finiteness of HTMLMediaElement properties. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fix LayoutTests, nits. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/HTMLMediaElement.cpp ('k') | Source/core/html/MediaController.h » ('j') | Source/core/html/MediaController.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLMediaElement.idl
diff --git a/Source/core/html/HTMLMediaElement.idl b/Source/core/html/HTMLMediaElement.idl
index cc30552dc518e54bda3ba529e7e2a98202a56c93..4cf00de3b09f03ef396d5cbeac9fb913c57720b3 100644
--- a/Source/core/html/HTMLMediaElement.idl
+++ b/Source/core/html/HTMLMediaElement.idl
@@ -57,11 +57,12 @@
readonly attribute boolean seeking;
// playback state
+ // FIXME: generated bindings should check isfinite: http://crbug.com/354298
[RaisesException=Setter] attribute double currentTime;
readonly attribute double duration;
readonly attribute boolean paused;
- attribute double defaultPlaybackRate;
- attribute double playbackRate;
+ [RaisesException=Setter] attribute double defaultPlaybackRate;
+ [RaisesException=Setter] attribute double playbackRate;
readonly attribute TimeRanges played;
readonly attribute TimeRanges seekable;
readonly attribute boolean ended;
« no previous file with comments | « Source/core/html/HTMLMediaElement.cpp ('k') | Source/core/html/MediaController.h » ('j') | Source/core/html/MediaController.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698