LayoutTests/media/video-volume-expected.txt - Issue 217053009: Validate finiteness of HTMLMediaElement properties.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/media/video-volume-expected.txt

Issue 217053009: Validate finiteness of HTMLMediaElement properties. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix LayoutTests, nits. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: LayoutTests/media/video-volume-expected.txt

diff --git a/LayoutTests/media/video-volume-expected.txt b/LayoutTests/media/video-volume-expected.txt

index 80856fae941541997a149989144dd251f43d9b5a..16bda544a50cd81c382f4623edb205039dfb9f87 100644

--- a/LayoutTests/media/video-volume-expected.txt

+++ b/LayoutTests/media/video-volume-expected.txt

@@ -9,6 +9,9 @@ RUN(video.volume = 0)

EXPECTED (video.volume == '0') OK

TEST(video.volume = 1.5) THROWS(DOMException.INDEX_SIZE_ERR: Failed to set the 'volume' property on 'HTMLMediaElement': The volume provided (1.5) is outside the range [0, 1].) OK

TEST(video.volume = -0.5) THROWS(DOMException.INDEX_SIZE_ERR: Failed to set the 'volume' property on 'HTMLMediaElement': The volume provided (-0.5) is outside the range [0, 1].) OK

+TEST(video.volume = -Infinity) THROWS("TypeError: Failed to set the 'volume' property on 'HTMLMediaElement': The value provided is infinite.") OK

+TEST(video.volume = Infinity) THROWS("TypeError: Failed to set the 'volume' property on 'HTMLMediaElement': The value provided is infinite.") OK

+TEST(video.volume = NaN) THROWS("TypeError: Failed to set the 'volume' property on 'HTMLMediaElement': The value provided is not a number.") OK

RUN(video.load())

EVENT(canplaythrough)

EXPECTED (video.volume == '0') OK

« no previous file with comments | « LayoutTests/media/video-volume.html ('k') | Source/core/html/HTMLMediaElement.h » ('j') | Source/core/html/MediaController.cpp » ('J')