Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Unified Diff: LayoutTests/media/video-test.js

Issue 217053009: Validate finiteness of HTMLMediaElement properties. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Add LayoutTests. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/media/video-test.js
diff --git a/LayoutTests/media/video-test.js b/LayoutTests/media/video-test.js
index e558c1db9a90094ddbfc71a27856c090e750edfb..3f73745a4ecd43c814c0be3bbaa811395bbcb695 100644
--- a/LayoutTests/media/video-test.js
+++ b/LayoutTests/media/video-test.js
@@ -225,7 +225,7 @@ function testException(testString, exceptionString) {
} catch (ex) {
var exception = ex;
}
- logResult(exception !== undefined && exception == eval(exceptionString),
+ logResult(exception !== undefined && exception + '' === exceptionString,
acolwell GONE FROM CHROMIUM 2014/03/29 01:40:08 Why did you need to make this change? This could p
sandersd (OOO until July 31) 2014/03/31 20:41:08 Looks like I didn't quite understand how the other
"TEST(" + testString + ") THROWS(" + exceptionString + ")");
}

Powered by Google App Engine
This is Rietveld 408576698