Validate finiteness of HTMLMediaElement properties.

Source/core/html/MediaController.cpp

 /*
  * Copyright (C) 2011 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 142 matching lines @@
         // Some clocks may return times outside the range of [0..duration].
         m_position = max(0.0, min(duration(), m_clock->currentTime()));
         m_clearPositionTimer.startOneShot(0, FROM_HERE);
     }
 
     return m_position;
 }
 
 void MediaController::setCurrentTime(double time, ExceptionState& exceptionState)
 {
+    if (!std::isfinite(time)) {

[acolwell GONE FROM CHROMIUM, 2014/03/31 21:58:29]

nit: You should probably add FIXME's to above this code, and everywhere else
you've added something similar, to indicate that this should be removed once the
bindings enforce this for us.

+        exceptionState.throwTypeError(ExceptionMessages::notAFiniteNumber(time));
+        return;
+    }
+
     // When the user agent is to seek the media controller to a particular new playback position,
     // it must follow these steps:
     // If the new playback position is less than zero, then set it to zero.
     time = max(0.0, time);
 
     // If the new playback position is greater than the media controller duration, then set it
     // to the media controller duration.
     time = min(time, duration());
 
     // Set the media controller position to the new playback position.
@@ skipping 38 matching lines @@
         return;
 
     // then the user agent must change the MediaController into a paused media controller,
     m_paused = true;
     // queue a task to fire a simple event named pause at the MediaController,
     scheduleEvent(EventTypeNames::pause);
     // and then report the controller state of the MediaController.
     reportControllerState();
 }
 
-void MediaController::setDefaultPlaybackRate(double rate)
+void MediaController::setDefaultPlaybackRate(double rate, ExceptionState& exceptionState)
 {
+    if (!std::isfinite(rate)) {
+        exceptionState.throwTypeError(ExceptionMessages::notAFiniteNumber(rate));
+        return;
+    }
+
     if (m_defaultPlaybackRate == rate)
         return;
 
     // The defaultPlaybackRate attribute, on setting, must set the MediaController's media controller
     // default playback rate to the new value,
     m_defaultPlaybackRate = rate;
 
     // then queue a task to fire a simple event named ratechange at the MediaController.
     scheduleEvent(EventTypeNames::ratechange);
 }
 
 double MediaController::playbackRate() const
 {
     return m_clock->playRate();
 }
 
-void MediaController::setPlaybackRate(double rate)
+void MediaController::setPlaybackRate(double rate, ExceptionState& exceptionState)
 {
+    if (!std::isfinite(rate)) {
+        exceptionState.throwTypeError(ExceptionMessages::notAFiniteNumber(rate));
+        return;
+    }
+
     if (m_clock->playRate() == rate)
         return;
 
     // The playbackRate attribute, on setting, must set the MediaController's media controller
     // playback rate to the new value,
     m_clock->setPlayRate(rate);
 
     for (size_t index = 0; index < m_mediaElements.size(); ++index)
         m_mediaElements[index]->updatePlaybackRate();
 
     // then queue a task to fire a simple event named ratechange at the MediaController.
     scheduleEvent(EventTypeNames::ratechange);
 }
 
 void MediaController::setVolume(double level, ExceptionState& exceptionState)
 {
+    if (!std::isfinite(level)) {
+        exceptionState.throwTypeError(ExceptionMessages::notAFiniteNumber(level));
+        return;
+    }
+
     if (m_volume == level)
         return;
 
     // If the new value is outside the range 0.0 to 1.0 inclusive, then, on setting, an
     // IndexSizeError exception must be raised instead.
     if (level < 0 || level > 1) {
         exceptionState.throwDOMException(IndexSizeError, ExceptionMessages::indexOutsideRange("volume", level, 0.0, ExceptionMessages::InclusiveBound, 1.0, ExceptionMessages::InclusiveBound));
         return;
     }
 
@@ skipping 346 matching lines @@
 {
     double now = WTF::currentTime();
     double timedelta = now - m_previousTimeupdateTime;
 
     if (timedelta < maxTimeupdateEventFrequency)
         return;
 
     scheduleEvent(EventTypeNames::timeupdate);
     m_previousTimeupdateTime = now;
 }