LayoutTests/media/media-controller-volume.html - Issue 217053009: Validate finiteness of HTMLMediaElement properties.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/media/media-controller-volume.html

Issue 217053009: Validate finiteness of HTMLMediaElement properties. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add LayoutTests. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/media/media-controller-playbackrate-expected.txt ('k') | LayoutTests/media/media-controller-volume-expected.txt » ('j') | LayoutTests/media/video-test.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <title>MediaController - volume test</title>

	5 <script src=video-test.js></script>

	6 <script src=media-file.js></script>

	7 <script>

	8 var start = function() {
	acolwell GONE FROM CHROMIUM 2014/03/29 01:40:08 nit: { on next line nit: { on next line sandersd (OOO until July 31) 2014/03/31 20:41:08 Done. Show quoted text On 2014/03/29 01:40:08, acolwell wrote: > nit: { on next line Done.
	9 findMediaElement();

	10 waitForEvent('canplay', canplay);

	11 video.src = findMediaFile("video", "content/test");

	12 };

	13

	14 var canplay = function() {
	acolwell GONE FROM CHROMIUM 2014/03/29 01:40:08 ditto ditto sandersd (OOO until July 31) 2014/03/31 20:41:08 Done. Show quoted text On 2014/03/29 01:40:08, acolwell wrote: > ditto Done.
	15 testExpected("video.controller.volume", 1.0);

	16 run("video.controller.volume = 0.5");

	17 testExpected("video.controller.volume", 0.5);

	18 run("video.controller.volume = Number.MIN_VALUE");

	19 testExpected("video.controller.volume", Number.MIN_VALUE);

	20 run("video.controller.volume = 0");

	21 testExpected("video.controller.volume", 0);

	22

	23 testDOMException("video.controller.volume = 1.5", "DOMException.INDEX_ SIZE_ERR");

	24 testDOMException("video.controller.volume = -0.5", "DOMException.INDEX _SIZE_ERR");

	25 testException("video.controller.volume = -Infinity", "TypeError: Faile d to set the 'volume' property on 'MediaController': The value provided is infin ite.");

	26 testException("video.controller.volume = Infinity", "TypeError: Failed to set the 'volume' property on 'MediaController': The value provided is infini te.");

	27 testException("video.controller.volume = NaN", "TypeError: Failed to s et the 'volume' property on 'MediaController': The value provided is not a numbe r.");

	28

	29 endTest();

	30 };

	31 </script>

	32 </head>

	33 <body>

	34 <body onload="start()">

	35 <video id="video" mediaGroup="group" controls autoplay></video>

	36 </body>

	37 </body>

	38 </html>

OLD	NEW