Source/web/FrameLoaderClientImpl.cpp - Issue 217053007: Revert of Make DOMWrapperWorld::current() return a reference instead of a pointer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/FrameLoaderClientImpl.cpp

Issue 217053007: Revert of Make DOMWrapperWorld::current() return a reference instead of a pointer (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Revert 213543004 too Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/FrameLoaderClientImpl.cpp

diff --git a/Source/web/FrameLoaderClientImpl.cpp b/Source/web/FrameLoaderClientImpl.cpp

index 9c2baa1796235706a4b78294f49cfe01418deefb..6597d61caa21cd3b215facd69d628e43347bf4da 100644

--- a/Source/web/FrameLoaderClientImpl.cpp

+++ b/Source/web/FrameLoaderClientImpl.cpp

@@ -110,10 +110,10 @@ FrameLoaderClientImpl::~FrameLoaderClientImpl()

{

}

-void FrameLoaderClientImpl::dispatchDidClearWindowObjectInWorld(DOMWrapperWorld& world)

+void FrameLoaderClientImpl::dispatchDidClearWindowObjectInWorld(DOMWrapperWorld* world)

{

if (m_webFrame->client()) {

- m_webFrame->client()->didClearWindowObject(m_webFrame, world.worldId());

+ m_webFrame->client()->didClearWindowObject(m_webFrame, world->worldId());

Document* document = m_webFrame->frame()->document();

if (document) {

WheelController::from(*document);

« no previous file with comments | « Source/web/FrameLoaderClientImpl.h ('k') | Source/web/tests/CustomEventTest.cpp » ('j') | no next file with comments »