Source/bindings/v8/V8AbstractEventListener.cpp - Issue 217053007: Revert of Make DOMWrapperWorld::current() return a reference instead of a pointer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/V8AbstractEventListener.cpp

Issue 217053007: Revert of Make DOMWrapperWorld::current() return a reference instead of a pointer (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Revert 213543004 too Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/v8/V8AbstractEventListener.cpp

diff --git a/Source/bindings/v8/V8AbstractEventListener.cpp b/Source/bindings/v8/V8AbstractEventListener.cpp

index dc7453750b664b6b1ac0ce3c6ee9e2dab0438d29..61720ea24cdda787b5402d75247c7e788b664d42 100644

--- a/Source/bindings/v8/V8AbstractEventListener.cpp

+++ b/Source/bindings/v8/V8AbstractEventListener.cpp

@@ -43,7 +43,7 @@

namespace WebCore {

-V8AbstractEventListener::V8AbstractEventListener(bool isAttribute, DOMWrapperWorld& world, v8::Isolate* isolate)

+V8AbstractEventListener::V8AbstractEventListener(bool isAttribute, DOMWrapperWorld* world, v8::Isolate* isolate)

: EventListener(JSEventListenerType)

, m_isAttribute(isAttribute)

, m_world(world)

@@ -177,7 +177,7 @@ v8::Local<v8::Object> V8AbstractEventListener::getReceiverObject(ExecutionContex

bool V8AbstractEventListener::belongsToTheCurrentWorld() const

{

- return m_isolate->InContext() && m_world == &DOMWrapperWorld::current(m_isolate);

+ return m_isolate->InContext() && m_world == DOMWrapperWorld::current(m_isolate);

}

void V8AbstractEventListener::setWeakCallback(const v8::WeakCallbackData<v8::Object, V8AbstractEventListener> &data)

« no previous file with comments | « Source/bindings/v8/V8AbstractEventListener.h ('k') | Source/bindings/v8/V8Binding.h » ('j') | no next file with comments »