Source/bindings/v8/custom/V8XMLHttpRequestCustom.cpp - Issue 217053007: Revert of Make DOMWrapperWorld::current() return a reference instead of a pointer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/custom/V8XMLHttpRequestCustom.cpp

Issue 217053007: Revert of Make DOMWrapperWorld::current() return a reference instead of a pointer (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Revert 213543004 too Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/v8/custom/V8XMLHttpRequestCustom.cpp

diff --git a/Source/bindings/v8/custom/V8XMLHttpRequestCustom.cpp b/Source/bindings/v8/custom/V8XMLHttpRequestCustom.cpp

index 83ccbbaca415b4e8f10f5c50b3ee63c287ac5762..c2422eff1b6c465461b13aabcd7358c811857b21 100644

--- a/Source/bindings/v8/custom/V8XMLHttpRequestCustom.cpp

+++ b/Source/bindings/v8/custom/V8XMLHttpRequestCustom.cpp

@@ -57,9 +57,9 @@ void V8XMLHttpRequest::constructorCustom(const v8::FunctionCallbackInfo<v8::Valu

RefPtr<SecurityOrigin> securityOrigin;

if (context->isDocument()) {

- DOMWrapperWorld& world = DOMWrapperWorld::current(info.GetIsolate());

- if (world.isIsolatedWorld())

- securityOrigin = world.isolatedWorldSecurityOrigin();

+ DOMWrapperWorld* world = DOMWrapperWorld::current(info.GetIsolate());

+ if (world->isIsolatedWorld())

+ securityOrigin = world->isolatedWorldSecurityOrigin();

}

RefPtrWillBeRawPtr<XMLHttpRequest> xmlHttpRequest = XMLHttpRequest::create(context, securityOrigin);

« no previous file with comments | « Source/bindings/v8/custom/V8TypedArrayCustom.h ('k') | Source/core/events/EventListener.h » ('j') | no next file with comments »