Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2635)

Side by Side Diff: Source/bindings/v8/custom/V8CustomEventCustom.cpp

Issue 217053007: Revert of Make DOMWrapperWorld::current() return a reference instead of a pointer (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Revert 213543004 too Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 74 matching lines...) Expand 10 before | Expand all | Expand 10 after
85 85
86 V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<>, typeArg, info[0]); 86 V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<>, typeArg, info[0]);
87 V8TRYCATCH_VOID(bool, canBubbleArg, info[1]->BooleanValue()); 87 V8TRYCATCH_VOID(bool, canBubbleArg, info[1]->BooleanValue());
88 V8TRYCATCH_VOID(bool, cancelableArg, info[2]->BooleanValue()); 88 V8TRYCATCH_VOID(bool, cancelableArg, info[2]->BooleanValue());
89 v8::Handle<v8::Value> detailsArg = info[3]; 89 v8::Handle<v8::Value> detailsArg = info[3];
90 90
91 event->initEvent(typeArg, canBubbleArg, cancelableArg); 91 event->initEvent(typeArg, canBubbleArg, cancelableArg);
92 92
93 if (!detailsArg.IsEmpty()) { 93 if (!detailsArg.IsEmpty()) {
94 V8HiddenValue::setHiddenValue(info.GetIsolate(), info.Holder(), V8Hidden Value::detail(info.GetIsolate()), detailsArg); 94 V8HiddenValue::setHiddenValue(info.GetIsolate(), info.Holder(), V8Hidden Value::detail(info.GetIsolate()), detailsArg);
95 if (DOMWrapperWorld::current(info.GetIsolate()).isIsolatedWorld()) 95 if (DOMWrapperWorld::current(info.GetIsolate())->isIsolatedWorld())
96 event->setSerializedDetail(SerializedScriptValue::createAndSwallowEx ceptions(detailsArg, info.GetIsolate())); 96 event->setSerializedDetail(SerializedScriptValue::createAndSwallowEx ceptions(detailsArg, info.GetIsolate()));
97 } 97 }
98 } 98 }
99 99
100 } // namespace WebCore 100 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/bindings/v8/custom/V8ArrayBufferCustom.h ('k') | Source/bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698