Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Unified Diff: chrome/browser/extensions/api/preference/preference_api.cc

Issue 217053003: Remove PreferenceAPI dependency from ExtensionPrefs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: woops Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/api/preference/preference_api.h ('k') | extensions/browser/DEPS » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/preference/preference_api.cc
diff --git a/chrome/browser/extensions/api/preference/preference_api.cc b/chrome/browser/extensions/api/preference/preference_api.cc
index c1e34ecba9b6e4de3862621d11509143d359aa90..dd1ae43e9980693bf0091d357051982f6642ff73 100644
--- a/chrome/browser/extensions/api/preference/preference_api.cc
+++ b/chrome/browser/extensions/api/preference/preference_api.cc
@@ -447,82 +447,6 @@ void PreferenceAPI::OnListenerAdded(const EventListenerInfo& details) {
ExtensionSystem::Get(profile_)->event_router()->UnregisterObserver(this);
}
-// static
-void PreferenceAPI::LoadExtensionControlledPrefs(
- ExtensionPrefs* prefs,
- ExtensionPrefValueMap* value_map,
- const std::string& extension_id,
- ExtensionPrefsScope scope) {
- std::string scope_string;
- if (!pref_names::ScopeToPrefName(scope, &scope_string))
- return;
- std::string key = extension_id + "." + scope_string;
-
- const base::DictionaryValue* source_dict = prefs->pref_service()->
- GetDictionary(pref_names::kExtensions);
- const base::DictionaryValue* preferences = NULL;
- if (!source_dict->GetDictionary(key, &preferences))
- return;
-
- for (base::DictionaryValue::Iterator iter(*preferences);
- !iter.IsAtEnd(); iter.Advance()) {
- value_map->SetExtensionPref(
- extension_id, iter.key(), scope, iter.value().DeepCopy());
- }
-}
-
-// static
-void PreferenceAPI::InitExtensionControlledPrefs(
- ExtensionPrefs* prefs,
- ExtensionPrefValueMap* value_map) {
- ExtensionIdList extension_ids;
- prefs->GetExtensions(&extension_ids);
-
- for (ExtensionIdList::iterator extension_id = extension_ids.begin();
- extension_id != extension_ids.end(); ++extension_id) {
- base::Time install_time = prefs->GetInstallTime(*extension_id);
- bool is_enabled = !prefs->IsExtensionDisabled(*extension_id);
- bool is_incognito_enabled = prefs->IsIncognitoEnabled(*extension_id);
- value_map->RegisterExtension(
- *extension_id, install_time, is_enabled, is_incognito_enabled);
- prefs->content_settings_store()->RegisterExtension(
- *extension_id, install_time, is_enabled);
-
- // Set regular extension controlled prefs.
- LoadExtensionControlledPrefs(prefs,
- value_map,
- *extension_id,
- kExtensionPrefsScopeRegular);
- // Set incognito extension controlled prefs.
- LoadExtensionControlledPrefs(prefs,
- value_map,
- *extension_id,
- kExtensionPrefsScopeIncognitoPersistent);
- // Set regular-only extension controlled prefs.
- LoadExtensionControlledPrefs(prefs,
- value_map,
- *extension_id,
- kExtensionPrefsScopeRegularOnly);
-
- // Set content settings.
- const base::ListValue* content_settings = NULL;
- if (prefs->ReadPrefAsList(*extension_id,
- pref_names::kPrefContentSettings,
- &content_settings)) {
- prefs->content_settings_store()->SetExtensionContentSettingFromList(
- *extension_id, content_settings, kExtensionPrefsScopeRegular);
- }
- if (prefs->ReadPrefAsList(*extension_id,
- pref_names::kPrefIncognitoContentSettings,
- &content_settings)) {
- prefs->content_settings_store()->SetExtensionContentSettingFromList(
- *extension_id,
- content_settings,
- kExtensionPrefsScopeIncognitoPersistent);
- }
- }
-}
-
void PreferenceAPI::OnContentSettingChanged(const std::string& extension_id,
bool incognito) {
if (incognito) {
« no previous file with comments | « chrome/browser/extensions/api/preference/preference_api.h ('k') | extensions/browser/DEPS » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698