Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 217053003: Remove PreferenceAPI dependency from ExtensionPrefs. (Closed)

Created:
6 years, 8 months ago by Ken Rockot(use gerrit already)
Modified:
6 years, 8 months ago
Reviewers:
scheib, James Cook
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Remove PreferenceAPI dependency from ExtensionPrefs. The only dependency here is on some static methods that are only used by ExtensionPrefs. These should live inside the ExtensionPrefs module. (clang_format also applied, pardon the dust) BUG=357634, 162530 R=scheib@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260272

Patch Set 1 #

Patch Set 2 : woops #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -92 lines) Patch
M chrome/browser/extensions/api/preference/preference_api.h View 1 chunk +0 lines, -13 lines 0 comments Download
M chrome/browser/extensions/api/preference/preference_api.cc View 1 chunk +0 lines, -76 lines 0 comments Download
M extensions/browser/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/browser/extension_prefs.cc View 1 3 chunks +70 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Ken Rockot(use gerrit already)
6 years, 8 months ago (2014-03-28 16:28:23 UTC) #1
scheib
lgtm
6 years, 8 months ago (2014-03-28 16:52:25 UTC) #2
scheib
lgtm lgtm
6 years, 8 months ago (2014-03-28 16:52:25 UTC) #3
Ken Rockot(use gerrit already)
The CQ bit was checked by rockot@chromium.org
6 years, 8 months ago (2014-03-28 16:54:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rockot@chromium.org/217053003/20001
6 years, 8 months ago (2014-03-28 16:57:07 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-28 17:31:59 UTC) #6
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=58293
6 years, 8 months ago (2014-03-28 17:31:59 UTC) #7
Ken Rockot(use gerrit already)
Oops, James can you please stamp for DEPS?
6 years, 8 months ago (2014-03-28 17:34:15 UTC) #8
James Cook
DEPS lgtm
6 years, 8 months ago (2014-03-28 17:43:04 UTC) #9
Ken Rockot(use gerrit already)
The CQ bit was checked by rockot@chromium.org
6 years, 8 months ago (2014-03-28 17:43:45 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rockot@chromium.org/217053003/20001
6 years, 8 months ago (2014-03-28 17:47:11 UTC) #11
commit-bot: I haz the power
6 years, 8 months ago (2014-03-28 21:00:16 UTC) #12
Message was sent while issue was closed.
Change committed as 260272

Powered by Google App Engine
This is Rietveld 408576698