[refactor] content::TextInputManager - Make some methods const and initialize/cleanup IME maps

[refactor] content::TextInputManager - Make some methods const and initialize/cleanup IME maps

This CL makes some getter methods in TextInputManager const. Also,
the CL will clean up and initialize maps at the time of unregistering
and registering with TextInputManager.

BUG=629842, 578168
Committed: https://crrev.com/4cfc03e1c2d8561641951e8843f4af4f52285703
Cr-Commit-Position: refs/heads/master@{#406891}

[EhsanK, 2016-07-20 14:54:36]

ekaramad@chromium.org changed reviewers:
+ creis@chromium.org

[EhsanK, 2016-07-20 14:54:37]

PTAL.

[EhsanK, 2016-07-20 14:54:42]

The CQ bit was checked by ekaramad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-20 14:55:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 15:35:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 15:35:08]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Charlie Reis, 2016-07-20 23:04:06]

Description was changed from

==========
[refactor] content::TextInputManager - Make some methods const and
initialize/cleanup IME maps

This CL makes some getter methods in TextInputManager const. Also,
the CL will clean up and initialize maps at the time of unregistering
and registering with TextInputManager.

BUG=629842, 578168
==========

to

==========
[refactor] content::TextInputManager - Make some methods const and
initialize/cleanup IME maps

This CL makes some getter methods in TextInputManager const. Also,
the CL will clean up and initialize maps at the time of unregistering
and registering with TextInputManager.

BUG=629842, 578168
==========

[Charlie Reis, 2016-07-20 23:08:20]

Heh, adding more consts after your previous encounter with them?  :)

Thanks for the initialization fix.  LGTM.

https://codereview.chromium.org/2170463002/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/text_input_manager.cc (right):

https://codereview.chromium.org/2170463002/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/text_input_manager.cc:182:
composition_range_info_map_[view] = CompositionRangeInfo();
Yikes.  I would suggest adding a comment to the .h file where this block of
members is declared, mentioning (reminding) they're initialized in Register and
cleared in Unregister (per view).

[EhsanK, 2016-07-21 16:06:02]

Thanks Charlie!

Yep making methods const is a bit ironic after what happened last week :P. But I
guess in this case we are making things easier, aren't we? I am open to
un-consting these if you think it is more appropriate. The important goal of the
CL was the initialization part which is achieved.

I will CQ after dry-run or in case you suggest removing the const, I will do it
after. Thanks!

https://codereview.chromium.org/2170463002/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/text_input_manager.cc (right):

https://codereview.chromium.org/2170463002/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/text_input_manager.cc:182:
composition_range_info_map_[view] = CompositionRangeInfo();
On 2016/07/20 23:08:20, Charlie Reis wrote:
> Yikes.  I would suggest adding a comment to the .h file where this block of
> members is declared, mentioning (reminding) they're initialized in Register
and
> cleared in Unregister (per view).

Done.

[Charlie Reis, 2016-07-21 16:24:58]

On 2016/07/21 16:06:02, EhsanK wrote:
> Thanks Charlie!
> 
> Yep making methods const is a bit ironic after what happened last week :P. But
I
> guess in this case we are making things easier, aren't we? I am open to
> un-consting these if you think it is more appropriate. The important goal of
the
> CL was the initialization part which is achieved.
> 
> I will CQ after dry-run or in case you suggest removing the const, I will do
it
> after. Thanks!
> 

Feel free to proceed!

[EhsanK, 2016-07-21 16:29:37]

The CQ bit was checked by ekaramad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-21 16:29:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[EhsanK, 2016-07-21 16:46:28]

The CQ bit was unchecked by ekaramad@chromium.org

[EhsanK, 2016-07-21 16:46:28]

The CQ bit was checked by ekaramad@chromium.org

[EhsanK, 2016-07-21 16:46:29]

The patchset sent to the CQ was uploaded after l-g-t-m from creis@chromium.org
Link to the patchset: https://codereview.chromium.org/2170463002/#ps40001
(title: "Adding a comment to .h file")

[commit-bot: I haz the power, 2016-07-21 16:46:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[EhsanK, 2016-07-21 16:46:51]

On 2016/07/21 16:24:58, Charlie Reis wrote:
> On 2016/07/21 16:06:02, EhsanK wrote:
> > Thanks Charlie!
> > 
> > Yep making methods const is a bit ironic after what happened last week :P.
But
> I
> > guess in this case we are making things easier, aren't we? I am open to
> > un-consting these if you think it is more appropriate. The important goal of
> the
> > CL was the initialization part which is achieved.
> > 
> > I will CQ after dry-run or in case you suggest removing the const, I will do
> it
> > after. Thanks!
> > 
> 
> Feel free to proceed!

Thanks!

[commit-bot: I haz the power, 2016-07-21 17:34:34]

Description was changed from

==========
[refactor] content::TextInputManager - Make some methods const and
initialize/cleanup IME maps

This CL makes some getter methods in TextInputManager const. Also,
the CL will clean up and initialize maps at the time of unregistering
and registering with TextInputManager.

BUG=629842, 578168
==========

to

==========
[refactor] content::TextInputManager - Make some methods const and
initialize/cleanup IME maps

This CL makes some getter methods in TextInputManager const. Also,
the CL will clean up and initialize maps at the time of unregistering
and registering with TextInputManager.

BUG=629842, 578168
==========

[commit-bot: I haz the power, 2016-07-21 17:34:35]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-21 17:37:58]

Description was changed from

==========
[refactor] content::TextInputManager - Make some methods const and
initialize/cleanup IME maps

This CL makes some getter methods in TextInputManager const. Also,
the CL will clean up and initialize maps at the time of unregistering
and registering with TextInputManager.

BUG=629842, 578168
==========

to

==========
[refactor] content::TextInputManager - Make some methods const and
initialize/cleanup IME maps

This CL makes some getter methods in TextInputManager const. Also,
the CL will clean up and initialize maps at the time of unregistering
and registering with TextInputManager.

BUG=629842, 578168

Committed: https://crrev.com/4cfc03e1c2d8561641951e8843f4af4f52285703
Cr-Commit-Position: refs/heads/master@{#406891}
==========

[commit-bot: I haz the power, 2016-07-21 17:37:59]

Patchset 3 (id:??) landed as
https://crrev.com/4cfc03e1c2d8561641951e8843f4af4f52285703
Cr-Commit-Position: refs/heads/master@{#406891}