Simplify URL-resolving in targetElementFromIRIString

Simplify URL-resolving in targetElementFromIRIString

Use Document::completeURL for URL resolving, rather than using
String::substring et.c to reproduce essentially the same code.
Use KURL::fragmentIdentifier and friends to extract the fragment
identifier.

Fold urlFromIRIStringWithFragmentIdentifier into its only user.
Open-code isExternalURIReference in targetElementFromIRIString, since we
already have the URL resolved and ready.

BUG=470608
Committed: https://crrev.com/7cae9a3466aa173c9e3127c8eb7f8079f932beca
Cr-Commit-Position: refs/heads/master@{#406578}

[fs, 2016-07-20 14:22:42]

The CQ bit was checked by fs@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-20 14:22:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fs, 2016-07-20 15:21:31]

fs@opera.com changed reviewers:
+ pdr@chromium.org, schenney@chromium.org

[Stephen Chennney, 2016-07-20 15:33:21]

Good cleanup. Probably dates from WebKit when only Chrome used KURL, or
something like that.

https://codereview.chromium.org/2170453002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/svg/SVGURIReference.cpp (right):

https://codereview.chromium.org/2170453002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/svg/SVGURIReference.cpp:84: return
externalDocument->getElementById(id);
Does this return nullptr for an empty id? Otherwise you've lost the check for
empty id.

https://codereview.chromium.org/2170453002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/svg/SVGURIReference.cpp:91: return
treeScope.getElementById(id);
Ditto.

[fs, 2016-07-20 15:41:03]

On 2016/07/20 at 15:33:21, schenney wrote:
> Good cleanup. Probably dates from WebKit when only Chrome used KURL, or
something like that.
> 
>
https://codereview.chromium.org/2170453002/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/svg/SVGURIReference.cpp (right):
> 
>
https://codereview.chromium.org/2170453002/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/svg/SVGURIReference.cpp:84: return
externalDocument->getElementById(id);
> Does this return nullptr for an empty id? Otherwise you've lost the check for
empty id.

Yes it does.
(https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/dom/TreeS...)

[Stephen Chennney, 2016-07-20 15:46:22]

On 2016/07/20 15:41:03, fs wrote:
> On 2016/07/20 at 15:33:21, schenney wrote:
> > Good cleanup. Probably dates from WebKit when only Chrome used KURL, or
> something like that.
> > 
> >
>
https://codereview.chromium.org/2170453002/diff/1/third_party/WebKit/Source/c...
> > File third_party/WebKit/Source/core/svg/SVGURIReference.cpp (right):
> > 
> >
>
https://codereview.chromium.org/2170453002/diff/1/third_party/WebKit/Source/c...
> > third_party/WebKit/Source/core/svg/SVGURIReference.cpp:84: return
> externalDocument->getElementById(id);
> > Does this return nullptr for an empty id? Otherwise you've lost the check
for
> empty id.
> 
> Yes it does.
>
(https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/dom/TreeS...)

Thanks for doing my legwork. LGTM.

[commit-bot: I haz the power, 2016-07-20 15:47:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 15:47:40]

Dry run: This issue passed the CQ dry run.

[fs, 2016-07-20 16:15:02]

The CQ bit was checked by fs@opera.com

[commit-bot: I haz the power, 2016-07-20 16:15:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 16:24:00]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-20 16:27:16]

Description was changed from

==========
Simplify URL-resolving in targetElementFromIRIString

Use Document::completeURL for URL resolving, rather than using
String::substring et.c to reproduce essentially the same code.
Use KURL::fragmentIdentifier and friends to extract the fragment
identifier.

Fold urlFromIRIStringWithFragmentIdentifier into its only user.
Open-code isExternalURIReference in targetElementFromIRIString, since we
already have the URL resolved and ready.

BUG=470608
==========

to

==========
Simplify URL-resolving in targetElementFromIRIString

Use Document::completeURL for URL resolving, rather than using
String::substring et.c to reproduce essentially the same code.
Use KURL::fragmentIdentifier and friends to extract the fragment
identifier.

Fold urlFromIRIStringWithFragmentIdentifier into its only user.
Open-code isExternalURIReference in targetElementFromIRIString, since we
already have the URL resolved and ready.

BUG=470608

Committed: https://crrev.com/7cae9a3466aa173c9e3127c8eb7f8079f932beca
Cr-Commit-Position: refs/heads/master@{#406578}
==========

[commit-bot: I haz the power, 2016-07-20 16:27:17]

Patchset 1 (id:??) landed as
https://crrev.com/7cae9a3466aa173c9e3127c8eb7f8079f932beca
Cr-Commit-Position: refs/heads/master@{#406578}