Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 217043003: Move OptionsUI browsertest away from listening for Signin notifications. (Closed)

Created:
6 years, 9 months ago by blundell
Modified:
6 years, 8 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, dbeam+watch-options_chromium.org
Visibility:
Public.

Description

Move OptionsUI browsertest away from listening for Signin notifications. This CL moves the OptionsUI browsertest from listening for Signin notifications to observing the SigninManager as part of eliminating Signin notifications. BUG=333997 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260449

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -6 lines) Patch
M chrome/browser/ui/webui/options/options_ui_browsertest.cc View 4 chunks +37 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
blundell
6 years, 9 months ago (2014-03-28 17:01:17 UTC) #1
Dan Beam
lgtm
6 years, 9 months ago (2014-03-28 20:47:58 UTC) #2
blundell
The CQ bit was checked by blundell@chromium.org
6 years, 9 months ago (2014-03-28 20:50:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/blundell@chromium.org/217043003/1
6 years, 9 months ago (2014-03-28 20:55:09 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-28 23:45:21 UTC) #5
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 9 months ago (2014-03-28 23:45:21 UTC) #6
blundell
The CQ bit was checked by blundell@chromium.org
6 years, 8 months ago (2014-03-29 07:24:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/blundell@chromium.org/217043003/1
6 years, 8 months ago (2014-03-29 07:24:56 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-29 08:03:04 UTC) #9
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) net_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=290853
6 years, 8 months ago (2014-03-29 08:03:05 UTC) #10
blundell
The CQ bit was checked by blundell@chromium.org
6 years, 8 months ago (2014-03-29 18:38:04 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/blundell@chromium.org/217043003/1
6 years, 8 months ago (2014-03-29 18:38:24 UTC) #12
commit-bot: I haz the power
6 years, 8 months ago (2014-03-30 17:30:58 UTC) #13
Message was sent while issue was closed.
Change committed as 260449

Powered by Google App Engine
This is Rietveld 408576698