third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinitionBuilder.cpp - Issue 2170383002: CustomElements: adopt node

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinitionBuilder.cpp

Issue 2170383002: CustomElements: adopt node (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: merge conflict resolution Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinitionBuilder.h ('k') | third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLElementCustom.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinitionBuilder.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinitionBuilder.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinitionBuilder.cpp

index 616d518cfbd18ee83d4dfc2d7814e168efd3d805..0c3bb65fd4c0bf72d73c49d1c7ee6ea1e2ea4933 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinitionBuilder.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinitionBuilder.cpp

@@ -156,9 +156,11 @@ bool ScriptCustomElementDefinitionBuilder::rememberOriginalProperties()

// CustomElementDefinition is built, even if JS changes them afterwards.

const String kConnectedCallback = "connectedCallback";

const String kDisconnectedCallback = "disconnectedCallback";

+ const String kAdoptedCallback = "adoptedCallback";

const String kAttributeChangedCallback = "attributeChangedCallback";

return callableForName(kConnectedCallback, m_connectedCallback)

&& callableForName(kDisconnectedCallback, m_disconnectedCallback)

+ && callableForName(kAdoptedCallback, m_adoptedCallback)

&& callableForName(kAttributeChangedCallback, m_attributeChangedCallback)

&& (m_attributeChangedCallback.IsEmpty() || retrieveObservedAttributes());

}

@@ -174,6 +176,7 @@ CustomElementDefinition* ScriptCustomElementDefinitionBuilder::build(

m_prototype,

m_connectedCallback,

m_disconnectedCallback,

+ m_adoptedCallback,

m_attributeChangedCallback,

m_observedAttributes);

}