third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.h - Issue 2170383002: CustomElements: adopt node

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.h

Issue 2170383002: CustomElements: adopt node (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: merge conflict resolution Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/custom-elements/spec/resources/custom-elements-helpers.js ('k') | third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.h b/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.h

index b6621d57053d3e91f36c0558907b94c2b68f7502..5b76fc0ff0561da935945897d9c57df693c66a9f 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.h

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.h

@@ -35,6 +35,7 @@ public:

const v8::Local<v8::Object>& prototype,

const v8::Local<v8::Function>& connectedCallback,

const v8::Local<v8::Function>& disconnectedCallback,

+ const v8::Local<v8::Function>& adoptedCallback,

const v8::Local<v8::Function>& attributeChangedCallback,

const HashSet<AtomicString>& observedAttributes);

@@ -54,9 +55,11 @@ public:

bool hasConnectedCallback() const override;

bool hasDisconnectedCallback() const override;

+ bool hasAdoptedCallback() const override;

void runConnectedCallback(Element*) override;

void runDisconnectedCallback(Element*) override;

+ void runAdoptedCallback(Element*) override;

void runAttributeChangedCallback(Element*, const QualifiedName&,

const AtomicString& oldValue, const AtomicString& newValue) override;

@@ -68,6 +71,7 @@ private:

const v8::Local<v8::Object>& prototype,

const v8::Local<v8::Function>& connectedCallback,

const v8::Local<v8::Function>& disconnectedCallback,

+ const v8::Local<v8::Function>& adoptedCallback,

const v8::Local<v8::Function>& attributeChangedCallback,

const HashSet<AtomicString>& observedAttributes);

@@ -84,6 +88,7 @@ private:

ScopedPersistent<v8::Object> m_prototype;

ScopedPersistent<v8::Function> m_connectedCallback;

ScopedPersistent<v8::Function> m_disconnectedCallback;

+ ScopedPersistent<v8::Function> m_adoptedCallback;

ScopedPersistent<v8::Function> m_attributeChangedCallback;

};