third_party/WebKit/Source/core/dom/custom/V0CustomElement.cpp - Issue 2170383002: CustomElements: adopt node

Unified Diff: third_party/WebKit/Source/core/dom/custom/V0CustomElement.cpp

Issue 2170383002: CustomElements: adopt node (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: layout test went from bad to good, deleting failure expectation Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/dom/custom/CustomElement.cpp ('K') | « third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/custom/V0CustomElement.cpp

diff --git a/third_party/WebKit/Source/core/dom/custom/V0CustomElement.cpp b/third_party/WebKit/Source/core/dom/custom/V0CustomElement.cpp

index be36cefc99a2982f3034cec0c7b9bbb2596ecbee..d810f984f00db472ad1ed105cbe882629888b69b 100644

--- a/third_party/WebKit/Source/core/dom/custom/V0CustomElement.cpp

+++ b/third_party/WebKit/Source/core/dom/custom/V0CustomElement.cpp

@@ -111,7 +111,7 @@ void V0CustomElement::define(Element* element, V0CustomElementDefinition* defini

break;

case Element::V0WaitingForUpgrade:

- element->setCustomElementDefinition(definition);

+ element->v0setCustomElementDefinition(definition);

dominicc (has gone to gerrit) 2016/08/03 07:56:56 Call this v0SetCustomElementDefinition; ie treat v

V0CustomElementScheduler::scheduleCallback(definition->callbacks(), element, V0CustomElementLifecycleCallbacks::CreatedCallback);

break;

}

@@ -120,7 +120,7 @@ void V0CustomElement::define(Element* element, V0CustomElementDefinition* defini

void V0CustomElement::attributeDidChange(Element* element, const AtomicString& name, const AtomicString& oldValue, const AtomicString& newValue)

{

DCHECK_EQ(element->getV0CustomElementState(), Element::V0Upgraded);

- V0CustomElementScheduler::scheduleAttributeChangedCallback(element->customElementDefinition()->callbacks(), element, name, oldValue, newValue);

+ V0CustomElementScheduler::scheduleAttributeChangedCallback(element->v0customElementDefinition()->callbacks(), element, name, oldValue, newValue);

}

void V0CustomElement::didAttach(Element* element, const Document& document)

@@ -128,7 +128,7 @@ void V0CustomElement::didAttach(Element* element, const Document& document)

DCHECK_EQ(element->getV0CustomElementState(), Element::V0Upgraded);

if (!document.domWindow())

return;

- V0CustomElementScheduler::scheduleCallback(element->customElementDefinition()->callbacks(), element, V0CustomElementLifecycleCallbacks::AttachedCallback);

+ V0CustomElementScheduler::scheduleCallback(element->v0customElementDefinition()->callbacks(), element, V0CustomElementLifecycleCallbacks::AttachedCallback);

}

void V0CustomElement::didDetach(Element* element, const Document& document)

@@ -136,7 +136,7 @@ void V0CustomElement::didDetach(Element* element, const Document& document)

DCHECK_EQ(element->getV0CustomElementState(), Element::V0Upgraded);

if (!document.domWindow())

return;

- V0CustomElementScheduler::scheduleCallback(element->customElementDefinition()->callbacks(), element, V0CustomElementLifecycleCallbacks::DetachedCallback);

+ V0CustomElementScheduler::scheduleCallback(element->v0customElementDefinition()->callbacks(), element, V0CustomElementLifecycleCallbacks::DetachedCallback);

}

void V0CustomElement::wasDestroyed(Element* element)

« third_party/WebKit/Source/core/dom/custom/CustomElement.cpp ('K') | « third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.cpp ('k') | no next file » | no next file with comments »