CustomElements: adopt node

third_party/WebKit/Source/core/dom/Element.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Peter Kelly (pmk@post.com)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  *           (C) 2007 David Smith (catfish.man@gmail.com)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc. All rights reserved.
  *           (C) 2007 Eric Seidel (eric@webkit.org)
  *
  * This library is free software; you can redistribute it and/or
@@ skipping 1923 matching lines @@
     if (!layoutObject)
         return;
     if (!layoutObject->hasLayer())
         return;
     layoutObject->layer()->setNeedsCompositingInputsUpdate();
     // Changes in the return value of requiresAcceleratedCompositing change if
     // the PaintLayer is self-painting.
     layoutObject->layer()->updateSelfPaintingLayer();
 }
 
-void Element::setCustomElementDefinition(V0CustomElementDefinition* definition)
+void Element::v0SetCustomElementDefinition(V0CustomElementDefinition* definition)
+{
+    if (!hasRareData() && !definition)
+        return;
+    DCHECK(!v0CustomElementDefinition());
+    ensureElementRareData().v0SetCustomElementDefinition(definition);
+}
+
+V0CustomElementDefinition* Element::v0CustomElementDefinition() const
+{
+    if (hasRareData())
+        return elementRareData()->v0CustomElementDefinition();
+    return nullptr;
+}
+
+void Element::setCustomElementDefinition(CustomElementDefinition* definition)

[davaajav, 2016/08/03 11:31:14]

I am not sure about not allowing setting the definition to nullptr. Is
"!definition" on the line 1961 not sufficient for checking whether definition is
set to nullptr? Please let me know if I am missing something.

 {
     if (!hasRareData() && !definition)
         return;
     DCHECK(!customElementDefinition());
     ensureElementRareData().setCustomElementDefinition(definition);
+    this->setCustomElementState(CustomElementState::Custom);
 }
 
-V0CustomElementDefinition* Element::customElementDefinition() const
+CustomElementDefinition* Element::customElementDefinition() const
 {
     if (hasRareData())
         return elementRareData()->customElementDefinition();
     return nullptr;
 }
 
 ShadowRoot* Element::createShadowRoot(const ScriptState* scriptState, ExceptionState& exceptionState)
 {
     HostsUsingFeatures::countMainWorldOnly(scriptState, document(), HostsUsingFeatures::Feature::ElementCreateShadowRoot);
     if (ShadowRoot* root = shadowRoot()) {
@@ skipping 1832 matching lines @@
 
 DEFINE_TRACE_WRAPPERS(Element)
 {
     if (hasRareData()) {
         visitor->traceWrappers(elementRareData());
     }
     ContainerNode::traceWrappers(visitor);
 }
 
 } // namespace blink