third_party/WebKit/LayoutTests/custom-elements/spec/adopt-node.html - Issue 2170383002: CustomElements: adopt node

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/custom-elements/spec/adopt-node.html

Issue 2170383002: CustomElements: adopt node (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/custom-elements/spec/adopt-node-expected.txt » ('j') | third_party/WebKit/LayoutTests/custom-elements/spec/adopt-node-expected.txt » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <title>Custom Elements: adopt node</title>

	3 <link rel="help" href="https://dom.spec.whatwg.org/#concept-node-adopt">

	4 <script src="../../resources/testharness.js"></script>

	5 <script src="../../resources/testharnessreport.js"></script>

	6 <script src="resources/custom-elements-helpers.js"></script>

	7 <body>

	8 <script>

	9

	10 'use strict'

	11 // 3.2 For each inclusiveDescendant in node’s shadow-including inclusive descend ants that is a custom

	12 // element, enqueue a custom element callback reaction with inclusiveDescendant,

	13 // callback name "adoptedCallback", and an empty argument list.

	14 test_with_window((w) => {

	15 let invocations = [];

	16 let doc = w.document;

	17 let a = doc.createElement('a-a');

	18 doc.body.appendChild(a);

	19 class X extends w.HTMLElement {

	20 constructor() {}

	21 adoptedCallback() { invocations.push(['adopted', this, arguments]); }

	22 }

	23 w.customElements.define('a-a', X);

	24 doc.adoptNode(a);

	25 assert_equals(invocations.length, 1);
	dominicc (has gone to gerrit) 2016/07/22 09:07:58 We're writing a lot of things which push records i We're writing a lot of things which push records into arrays. Could we write something that lets us write one readable matcher? like assert_array_equals but it knows how to inspect its arguments? And then let's use it in all of these tests. The goal would be to maximize readability. It would be good to develop it in this test, and in a follow up change move it to custom-elements-helpers and make all of our tests use it.
	26 assert_array_equals(invocations[0].slice(0,2), ['adopted', a], 'the adoptedCal lback should be invoked');
	dominicc (has gone to gerrit) 2016/07/22 09:07:58 space after , space after ,
	27 assert_array_equals(invocations[0][0], [], 'the adoptedCallback should be invo ked with empty argumnets');
	dominicc (has gone to gerrit) 2016/07/22 09:07:58 spelling: arguments spelling: arguments
	28 }, 'adopting a custom element to the same document should enqueue an adoptedCall back reaction');

	29 </script>

	30 </body>

OLD	NEW