Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Unified Diff: test/unittests/compiler/mips/instruction-selector-mips-unittest.cc

Issue 2170343002: [turbofan] Change Float64Max/Float64Min to JavaScript semantics. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: mips/mips64 ports. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/unittests/compiler/mips/instruction-selector-mips-unittest.cc
diff --git a/test/unittests/compiler/mips/instruction-selector-mips-unittest.cc b/test/unittests/compiler/mips/instruction-selector-mips-unittest.cc
index 122c398e2069be5cce19063a6d4a713a14c5f5f4..7b5c667261551f05f31b917a2ebffef68d28ec09 100644
--- a/test/unittests/compiler/mips/instruction-selector-mips-unittest.cc
+++ b/test/unittests/compiler/mips/instruction-selector-mips-unittest.cc
@@ -1150,40 +1150,6 @@ TEST_F(InstructionSelectorTest, Float64Abs) {
}
-TEST_F(InstructionSelectorTest, Float32Max) {
- StreamBuilder m(this, MachineType::Float32(), MachineType::Float32(),
- MachineType::Float32());
- Node* const p0 = m.Parameter(0);
- Node* const p1 = m.Parameter(1);
- Node* const n = m.Float32Max(p0, p1);
- m.Return(n);
- Stream s = m.Build();
- // Float32Max is `(b < a) ? a : b`.
- ASSERT_EQ(1U, s.size());
- EXPECT_EQ(kMipsFloat32Max, s[0]->arch_opcode());
- ASSERT_EQ(2U, s[0]->InputCount());
- ASSERT_EQ(1U, s[0]->OutputCount());
- EXPECT_EQ(s.ToVreg(n), s.ToVreg(s[0]->Output()));
-}
-
-
-TEST_F(InstructionSelectorTest, Float32Min) {
- StreamBuilder m(this, MachineType::Float32(), MachineType::Float32(),
- MachineType::Float32());
- Node* const p0 = m.Parameter(0);
- Node* const p1 = m.Parameter(1);
- Node* const n = m.Float32Min(p0, p1);
- m.Return(n);
- Stream s = m.Build();
- // Float32Min is `(a < b) ? a : b`.
- ASSERT_EQ(1U, s.size());
- EXPECT_EQ(kMipsFloat32Min, s[0]->arch_opcode());
- ASSERT_EQ(2U, s[0]->InputCount());
- ASSERT_EQ(1U, s[0]->OutputCount());
- EXPECT_EQ(s.ToVreg(n), s.ToVreg(s[0]->Output()));
-}
-
-
TEST_F(InstructionSelectorTest, Float64Max) {
StreamBuilder m(this, MachineType::Float64(), MachineType::Float64(),
MachineType::Float64());
@@ -1192,7 +1158,6 @@ TEST_F(InstructionSelectorTest, Float64Max) {
Node* const n = m.Float64Max(p0, p1);
m.Return(n);
Stream s = m.Build();
- // Float64Max is `(b < a) ? a : b`.
ASSERT_EQ(1U, s.size());
EXPECT_EQ(kMipsFloat64Max, s[0]->arch_opcode());
ASSERT_EQ(2U, s[0]->InputCount());
@@ -1209,7 +1174,6 @@ TEST_F(InstructionSelectorTest, Float64Min) {
Node* const n = m.Float64Min(p0, p1);
m.Return(n);
Stream s = m.Build();
- // Float64Min is `(a < b) ? a : b`.
ASSERT_EQ(1U, s.size());
EXPECT_EQ(kMipsFloat64Min, s[0]->arch_opcode());
ASSERT_EQ(2U, s[0]->InputCount());
@@ -1217,7 +1181,6 @@ TEST_F(InstructionSelectorTest, Float64Min) {
EXPECT_EQ(s.ToVreg(n), s.ToVreg(s[0]->Output()));
}
-
} // namespace compiler
} // namespace internal
} // namespace v8

Powered by Google App Engine
This is Rietveld 408576698