Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1221)

Unified Diff: test/unittests/compiler/common-operator-reducer-unittest.cc

Issue 2170343002: [turbofan] Change Float64Max/Float64Min to JavaScript semantics. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: mips/mips64 ports. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/unittests/compiler/common-operator-reducer-unittest.cc
diff --git a/test/unittests/compiler/common-operator-reducer-unittest.cc b/test/unittests/compiler/common-operator-reducer-unittest.cc
index 510eaadf1d54f7cf6fcf3eeccd6c6c17c1f09e76..f51a54d074c96cc141fc9378a213a708a080f1ec 100644
--- a/test/unittests/compiler/common-operator-reducer-unittest.cc
+++ b/test/unittests/compiler/common-operator-reducer-unittest.cc
@@ -324,78 +324,6 @@ TEST_F(CommonOperatorReducerTest, PhiToFloat64Abs) {
}
-TEST_F(CommonOperatorReducerTest, PhiToFloat32Max) {
- Node* p0 = Parameter(0);
- Node* p1 = Parameter(1);
- Node* check = graph()->NewNode(machine()->Float32LessThan(), p0, p1);
- Node* branch = graph()->NewNode(common()->Branch(), check, graph()->start());
- Node* if_true = graph()->NewNode(common()->IfTrue(), branch);
- Node* if_false = graph()->NewNode(common()->IfFalse(), branch);
- Node* merge = graph()->NewNode(common()->Merge(2), if_true, if_false);
- Node* phi = graph()->NewNode(
- common()->Phi(MachineRepresentation::kFloat32, 2), p1, p0, merge);
- StrictMock<MockAdvancedReducerEditor> editor;
- EXPECT_CALL(editor, Revisit(merge));
- Reduction r = Reduce(&editor, phi, MachineOperatorBuilder::kFloat32Max);
- ASSERT_TRUE(r.Changed());
- EXPECT_THAT(r.replacement(), IsFloat32Max(p1, p0));
-}
-
-
-TEST_F(CommonOperatorReducerTest, PhiToFloat64Max) {
- Node* p0 = Parameter(0);
- Node* p1 = Parameter(1);
- Node* check = graph()->NewNode(machine()->Float64LessThan(), p0, p1);
- Node* branch = graph()->NewNode(common()->Branch(), check, graph()->start());
- Node* if_true = graph()->NewNode(common()->IfTrue(), branch);
- Node* if_false = graph()->NewNode(common()->IfFalse(), branch);
- Node* merge = graph()->NewNode(common()->Merge(2), if_true, if_false);
- Node* phi = graph()->NewNode(
- common()->Phi(MachineRepresentation::kFloat64, 2), p1, p0, merge);
- StrictMock<MockAdvancedReducerEditor> editor;
- EXPECT_CALL(editor, Revisit(merge));
- Reduction r = Reduce(&editor, phi, MachineOperatorBuilder::kFloat64Max);
- ASSERT_TRUE(r.Changed());
- EXPECT_THAT(r.replacement(), IsFloat64Max(p1, p0));
-}
-
-
-TEST_F(CommonOperatorReducerTest, PhiToFloat32Min) {
- Node* p0 = Parameter(0);
- Node* p1 = Parameter(1);
- Node* check = graph()->NewNode(machine()->Float32LessThan(), p0, p1);
- Node* branch = graph()->NewNode(common()->Branch(), check, graph()->start());
- Node* if_true = graph()->NewNode(common()->IfTrue(), branch);
- Node* if_false = graph()->NewNode(common()->IfFalse(), branch);
- Node* merge = graph()->NewNode(common()->Merge(2), if_true, if_false);
- Node* phi = graph()->NewNode(
- common()->Phi(MachineRepresentation::kFloat32, 2), p0, p1, merge);
- StrictMock<MockAdvancedReducerEditor> editor;
- EXPECT_CALL(editor, Revisit(merge));
- Reduction r = Reduce(&editor, phi, MachineOperatorBuilder::kFloat32Min);
- ASSERT_TRUE(r.Changed());
- EXPECT_THAT(r.replacement(), IsFloat32Min(p0, p1));
-}
-
-
-TEST_F(CommonOperatorReducerTest, PhiToFloat64Min) {
- Node* p0 = Parameter(0);
- Node* p1 = Parameter(1);
- Node* check = graph()->NewNode(machine()->Float64LessThan(), p0, p1);
- Node* branch = graph()->NewNode(common()->Branch(), check, graph()->start());
- Node* if_true = graph()->NewNode(common()->IfTrue(), branch);
- Node* if_false = graph()->NewNode(common()->IfFalse(), branch);
- Node* merge = graph()->NewNode(common()->Merge(2), if_true, if_false);
- Node* phi = graph()->NewNode(
- common()->Phi(MachineRepresentation::kFloat64, 2), p0, p1, merge);
- StrictMock<MockAdvancedReducerEditor> editor;
- EXPECT_CALL(editor, Revisit(merge));
- Reduction r = Reduce(&editor, phi, MachineOperatorBuilder::kFloat64Min);
- ASSERT_TRUE(r.Changed());
- EXPECT_THAT(r.replacement(), IsFloat64Min(p0, p1));
-}
-
-
// -----------------------------------------------------------------------------
// Return
@@ -514,54 +442,6 @@ TEST_F(CommonOperatorReducerTest, SelectToFloat64Abs) {
EXPECT_THAT(r.replacement(), IsFloat64Abs(p0));
}
-
-TEST_F(CommonOperatorReducerTest, SelectToFloat32Max) {
- Node* p0 = Parameter(0);
- Node* p1 = Parameter(1);
- Node* check = graph()->NewNode(machine()->Float32LessThan(), p0, p1);
- Node* select = graph()->NewNode(
- common()->Select(MachineRepresentation::kFloat32), check, p1, p0);
- Reduction r = Reduce(select, MachineOperatorBuilder::kFloat32Max);
- ASSERT_TRUE(r.Changed());
- EXPECT_THAT(r.replacement(), IsFloat32Max(p1, p0));
-}
-
-
-TEST_F(CommonOperatorReducerTest, SelectToFloat64Max) {
- Node* p0 = Parameter(0);
- Node* p1 = Parameter(1);
- Node* check = graph()->NewNode(machine()->Float64LessThan(), p0, p1);
- Node* select = graph()->NewNode(
- common()->Select(MachineRepresentation::kFloat64), check, p1, p0);
- Reduction r = Reduce(select, MachineOperatorBuilder::kFloat64Max);
- ASSERT_TRUE(r.Changed());
- EXPECT_THAT(r.replacement(), IsFloat64Max(p1, p0));
-}
-
-
-TEST_F(CommonOperatorReducerTest, SelectToFloat32Min) {
- Node* p0 = Parameter(0);
- Node* p1 = Parameter(1);
- Node* check = graph()->NewNode(machine()->Float32LessThan(), p0, p1);
- Node* select = graph()->NewNode(
- common()->Select(MachineRepresentation::kFloat32), check, p0, p1);
- Reduction r = Reduce(select, MachineOperatorBuilder::kFloat32Min);
- ASSERT_TRUE(r.Changed());
- EXPECT_THAT(r.replacement(), IsFloat32Min(p0, p1));
-}
-
-
-TEST_F(CommonOperatorReducerTest, SelectToFloat64Min) {
- Node* p0 = Parameter(0);
- Node* p1 = Parameter(1);
- Node* check = graph()->NewNode(machine()->Float64LessThan(), p0, p1);
- Node* select = graph()->NewNode(
- common()->Select(MachineRepresentation::kFloat64), check, p0, p1);
- Reduction r = Reduce(select, MachineOperatorBuilder::kFloat64Min);
- ASSERT_TRUE(r.Changed());
- EXPECT_THAT(r.replacement(), IsFloat64Min(p0, p1));
-}
-
} // namespace compiler
} // namespace internal
} // namespace v8

Powered by Google App Engine
This is Rietveld 408576698