Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1145)

Unified Diff: test/unittests/compiler/arm64/instruction-selector-arm64-unittest.cc

Issue 2170343002: [turbofan] Change Float64Max/Float64Min to JavaScript semantics. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: mips/mips64 ports. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/unittests/compiler/arm64/instruction-selector-arm64-unittest.cc
diff --git a/test/unittests/compiler/arm64/instruction-selector-arm64-unittest.cc b/test/unittests/compiler/arm64/instruction-selector-arm64-unittest.cc
index 8d2b36dddd704684ab5d7cfb510ad11b22d454c1..ae4cff92b25e2e167defcee7c23f081bd292b85e 100644
--- a/test/unittests/compiler/arm64/instruction-selector-arm64-unittest.cc
+++ b/test/unittests/compiler/arm64/instruction-selector-arm64-unittest.cc
@@ -4151,44 +4151,6 @@ TEST_F(InstructionSelectorTest, Float64SubWithMinusZero) {
}
-TEST_F(InstructionSelectorTest, Float32Max) {
- StreamBuilder m(this, MachineType::Float32(), MachineType::Float32(),
- MachineType::Float32());
- Node* const p0 = m.Parameter(0);
- Node* const p1 = m.Parameter(1);
- Node* const n = m.Float32Max(p0, p1);
- m.Return(n);
- Stream s = m.Build();
- // Float32Max is `(b < a) ? a : b`.
- ASSERT_EQ(1U, s.size());
- EXPECT_EQ(kArm64Float32Max, s[0]->arch_opcode());
- ASSERT_EQ(2U, s[0]->InputCount());
- EXPECT_EQ(s.ToVreg(p0), s.ToVreg(s[0]->InputAt(0)));
- EXPECT_EQ(s.ToVreg(p1), s.ToVreg(s[0]->InputAt(1)));
- ASSERT_EQ(1U, s[0]->OutputCount());
- EXPECT_EQ(s.ToVreg(n), s.ToVreg(s[0]->Output()));
-}
-
-
-TEST_F(InstructionSelectorTest, Float32Min) {
- StreamBuilder m(this, MachineType::Float32(), MachineType::Float32(),
- MachineType::Float32());
- Node* const p0 = m.Parameter(0);
- Node* const p1 = m.Parameter(1);
- Node* const n = m.Float32Min(p0, p1);
- m.Return(n);
- Stream s = m.Build();
- // Float32Min is `(a < b) ? a : b`.
- ASSERT_EQ(1U, s.size());
- EXPECT_EQ(kArm64Float32Min, s[0]->arch_opcode());
- ASSERT_EQ(2U, s[0]->InputCount());
- EXPECT_EQ(s.ToVreg(p0), s.ToVreg(s[0]->InputAt(0)));
- EXPECT_EQ(s.ToVreg(p1), s.ToVreg(s[0]->InputAt(1)));
- ASSERT_EQ(1U, s[0]->OutputCount());
- EXPECT_EQ(s.ToVreg(n), s.ToVreg(s[0]->Output()));
-}
-
-
TEST_F(InstructionSelectorTest, Float64Max) {
StreamBuilder m(this, MachineType::Float64(), MachineType::Float64(),
MachineType::Float64());
@@ -4197,7 +4159,6 @@ TEST_F(InstructionSelectorTest, Float64Max) {
Node* const n = m.Float64Max(p0, p1);
m.Return(n);
Stream s = m.Build();
- // Float64Max is `(b < a) ? a : b`.
ASSERT_EQ(1U, s.size());
EXPECT_EQ(kArm64Float64Max, s[0]->arch_opcode());
ASSERT_EQ(2U, s[0]->InputCount());
@@ -4216,7 +4177,6 @@ TEST_F(InstructionSelectorTest, Float64Min) {
Node* const n = m.Float64Min(p0, p1);
m.Return(n);
Stream s = m.Build();
- // Float64Min is `(a < b) ? a : b`.
ASSERT_EQ(1U, s.size());
EXPECT_EQ(kArm64Float64Min, s[0]->arch_opcode());
ASSERT_EQ(2U, s[0]->InputCount());

Powered by Google App Engine
This is Rietveld 408576698