Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(729)

Unified Diff: src/compiler/common-operator-reducer.cc

Issue 2170343002: [turbofan] Change Float64Max/Float64Min to JavaScript semantics. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: mips/mips64 ports. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/arm64/instruction-selector-arm64.cc ('k') | src/compiler/ia32/code-generator-ia32.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/common-operator-reducer.cc
diff --git a/src/compiler/common-operator-reducer.cc b/src/compiler/common-operator-reducer.cc
index acb7f26cf9dcdb7413193e5f900e8d235ee8d90c..9527c754e4ebdc4fd4400b97de82d997fbae0cc9 100644
--- a/src/compiler/common-operator-reducer.cc
+++ b/src/compiler/common-operator-reducer.cc
@@ -247,17 +247,6 @@ Reduction CommonOperatorReducer::ReducePhi(Node* node) {
return Change(node, machine()->Float32Abs(), vtrue);
}
}
- if (mcond.left().Equals(vtrue) && mcond.right().Equals(vfalse) &&
- machine()->Float32Min().IsSupported()) {
- // We might now be able to further reduce the {merge} node.
- Revisit(merge);
- return Change(node, machine()->Float32Min().op(), vtrue, vfalse);
- } else if (mcond.left().Equals(vfalse) && mcond.right().Equals(vtrue) &&
- machine()->Float32Max().IsSupported()) {
- // We might now be able to further reduce the {merge} node.
- Revisit(merge);
- return Change(node, machine()->Float32Max().op(), vtrue, vfalse);
- }
} else if (cond->opcode() == IrOpcode::kFloat64LessThan) {
Float64BinopMatcher mcond(cond);
if (mcond.left().Is(0.0) && mcond.right().Equals(vtrue) &&
@@ -269,17 +258,6 @@ Reduction CommonOperatorReducer::ReducePhi(Node* node) {
return Change(node, machine()->Float64Abs(), vtrue);
}
}
- if (mcond.left().Equals(vtrue) && mcond.right().Equals(vfalse) &&
- machine()->Float64Min().IsSupported()) {
- // We might now be able to further reduce the {merge} node.
- Revisit(merge);
- return Change(node, machine()->Float64Min().op(), vtrue, vfalse);
- } else if (mcond.left().Equals(vfalse) && mcond.right().Equals(vtrue) &&
- machine()->Float64Max().IsSupported()) {
- // We might now be able to further reduce the {merge} node.
- Revisit(merge);
- return Change(node, machine()->Float64Max().op(), vtrue, vfalse);
- }
}
}
}
@@ -365,13 +343,6 @@ Reduction CommonOperatorReducer::ReduceSelect(Node* node) {
return Change(node, machine()->Float32Abs(), vtrue);
}
}
- if (mcond.left().Equals(vtrue) && mcond.right().Equals(vfalse) &&
- machine()->Float32Min().IsSupported()) {
- return Change(node, machine()->Float32Min().op(), vtrue, vfalse);
- } else if (mcond.left().Equals(vfalse) && mcond.right().Equals(vtrue) &&
- machine()->Float32Max().IsSupported()) {
- return Change(node, machine()->Float32Max().op(), vtrue, vfalse);
- }
break;
}
case IrOpcode::kFloat64LessThan: {
@@ -383,13 +354,6 @@ Reduction CommonOperatorReducer::ReduceSelect(Node* node) {
return Change(node, machine()->Float64Abs(), vtrue);
}
}
- if (mcond.left().Equals(vtrue) && mcond.right().Equals(vfalse) &&
- machine()->Float64Min().IsSupported()) {
- return Change(node, machine()->Float64Min().op(), vtrue, vfalse);
- } else if (mcond.left().Equals(vfalse) && mcond.right().Equals(vtrue) &&
- machine()->Float64Max().IsSupported()) {
- return Change(node, machine()->Float64Max().op(), vtrue, vfalse);
- }
break;
}
default:
« no previous file with comments | « src/compiler/arm64/instruction-selector-arm64.cc ('k') | src/compiler/ia32/code-generator-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698