[x64]: add cmpps/cmppd instructions

[x64]: add cmpps/cmppd instructions

BUG=

Committed: https://crrev.com/0872d08b0074571e23712a252cb3d1791ef7d2aa
Cr-Commit-Position: refs/heads/master@{#38307}

[Weiliang, 2016-07-22 07:00:43]

Patchset #1 (id:1) has been deleted

[Weiliang, 2016-07-22 07:02:06]

weiliang.lin@intel.com changed reviewers:
+ bbudge@chromium.org, bmeurer@chromium.org, gdeepti@google.com

[Weiliang, 2016-07-22 07:02:06]

PTAL

[bbudge, 2016-07-22 12:18:24]

https://codereview.chromium.org/2170323002/diff/20001/src/x64/assembler-x64.h
File src/x64/assembler-x64.h (right):

https://codereview.chromium.org/2170323002/diff/20001/src/x64/assembler-x64.h...
src/x64/assembler-x64.h:1177: void cmppd(XMMRegister dst, const Operand& src,
int8_t cmp);
The SIMD.js spec doesn't include the float64x2 type, so cmppd may not be needed.
Web Assembly doesn't have a spec, but we weren't anticipating adding this type
right off the bat.

The SIMD.js types are: float32x4, int32x4, bool32x4, int16x8, bool16x8, int8x16,
and bool8x16.

[Weiliang, 2016-07-22 12:52:30]

Description was changed from

==========
[x64]: add packed float/double compare instructions

BUG=
==========

to

==========
[x64]: add cmpps instructions

BUG=
==========

[Weiliang, 2016-07-22 12:53:27]

On 2016/07/22 12:18:24, bbudge wrote:
> https://codereview.chromium.org/2170323002/diff/20001/src/x64/assembler-x64.h
> File src/x64/assembler-x64.h (right):
> 
>
https://codereview.chromium.org/2170323002/diff/20001/src/x64/assembler-x64.h...
> src/x64/assembler-x64.h:1177: void cmppd(XMMRegister dst, const Operand& src,
> int8_t cmp);
> The SIMD.js spec doesn't include the float64x2 type, so cmppd may not be
needed.
> Web Assembly doesn't have a spec, but we weren't anticipating adding this type
> right off the bat.
> 
> The SIMD.js types are: float32x4, int32x4, bool32x4, int16x8, bool16x8,
int8x16,
> and bool8x16.

Done.

PTAL

[bbudge, 2016-08-01 18:05:45]

Looking at the Portable SIMD spec and the wasm mapping, there is a float64x2
type. So I think you should add it back. Sorry for the misdirection!

https://github.com/stoklund/portable-simd/blob/master/webassembly-mapping.md

[Weiliang, 2016-08-03 06:37:40]

Patchset #2 (id:40001) has been deleted

[Weiliang, 2016-08-03 06:39:13]

Description was changed from

==========
[x64]: add cmpps instructions

BUG=
==========

to

==========
[x64]: add cmpps/cmppd instructions

BUG=
==========

[Weiliang, 2016-08-03 06:39:54]

On 2016/08/01 18:05:45, bbudge wrote:
> Looking at the Portable SIMD spec and the wasm mapping, there is a float64x2
> type. So I think you should add it back. Sorry for the misdirection!
> 
> https://github.com/stoklund/portable-simd/blob/master/webassembly-mapping.md

Done

[bbudge, 2016-08-03 13:44:07]

lgtm

[Weiliang, 2016-08-03 15:03:19]

The CQ bit was checked by weiliang.lin@intel.com

[commit-bot: I haz the power, 2016-08-03 15:03:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-03 15:24:01]

Description was changed from

==========
[x64]: add cmpps/cmppd instructions

BUG=
==========

to

==========
[x64]: add cmpps/cmppd instructions

BUG=
==========

[commit-bot: I haz the power, 2016-08-03 15:24:02]

Committed patchset #1 (id:20001)

[commit-bot: I haz the power, 2016-08-03 15:25:32]

Description was changed from

==========
[x64]: add cmpps/cmppd instructions

BUG=
==========

to

==========
[x64]: add cmpps/cmppd instructions

BUG=

Committed: https://crrev.com/0872d08b0074571e23712a252cb3d1791ef7d2aa
Cr-Commit-Position: refs/heads/master@{#38307}
==========

[commit-bot: I haz the power, 2016-08-03 15:25:33]

Patchset 1 (id:??) landed as
https://crrev.com/0872d08b0074571e23712a252cb3d1791ef7d2aa
Cr-Commit-Position: refs/heads/master@{#38307}