Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Unified Diff: content/browser/renderer_host/render_process_host_impl.h

Issue 2170313002: Remove OwnedInterface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address review comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_process_host_impl.h
diff --git a/content/browser/renderer_host/render_process_host_impl.h b/content/browser/renderer_host/render_process_host_impl.h
index ecd008b2b4b66993467785f5c279d38d61ef2c0d..481fad99ceb65002ab1e7e4e2e160eb6db735df8 100644
--- a/content/browser/renderer_host/render_process_host_impl.h
+++ b/content/browser/renderer_host/render_process_host_impl.h
@@ -55,7 +55,6 @@ class InProcessChildThreadParams;
class MessagePortMessageFilter;
class MojoChildConnection;
class NotificationMessageFilter;
-class OwnedInterface;
#if defined(ENABLE_WEBRTC)
class P2PSocketDispatcherHost;
#endif
@@ -137,7 +136,6 @@ class CONTENT_EXPORT RenderProcessHostImpl
bool SuddenTerminationAllowed() const override;
IPC::ChannelProxy* GetChannel() override;
void AddFilter(BrowserMessageFilter* filter) override;
- void AddOwnedInterface(std::unique_ptr<OwnedInterface> impl) override;
bool FastShutdownForPageCount(size_t count) override;
bool FastShutdownStarted() const override;
base::TimeDelta GetChildProcessIdleTime() const override;
@@ -360,11 +358,6 @@ class CONTENT_EXPORT RenderProcessHostImpl
std::string child_token_;
- // Services owned by this host for the purpose of service impl lifetime
- // management. These need to outlive |mojo_child_connection_|, as they are
- // registered on the |InterfaceRegistry| indirectly owned by that object.
- std::vector<std::unique_ptr<OwnedInterface>> owned_interface_impls_;
-
std::unique_ptr<MojoChildConnection> mojo_child_connection_;
shell::mojom::ServicePtr test_service_;

Powered by Google App Engine
This is Rietveld 408576698