Make MSE buffer sizes configurable via command line

media/filters/media_source_state.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/filters/media_source_state.h"
 
 #include "base/callback_helpers.h"
+#include "base/command_line.h"
 #include "base/stl_util.h"
+#include "base/strings/string_number_conversions.h"
+#include "media/base/media_switches.h"
 #include "media/base/media_track.h"
 #include "media/base/media_tracks.h"
 #include "media/filters/chunk_demuxer.h"
 #include "media/filters/frame_processor.h"
 #include "media/filters/source_buffer_stream.h"
 
 namespace media {
 
 enum {
   // Limits the number of MEDIA_LOG() calls warning the user that a muxed stream
@@ skipping 555 matching lines @@
     }
 
     if (!audio_) {
       audio_ = create_demuxer_stream_cb_.Run(DemuxerStream::AUDIO);
 
       if (!audio_) {
         DVLOG(1) << "Failed to create an audio stream.";
         return false;
       }
 
+      std::string audioBufferSwitchStr =

[wolenetz, 2016/07/28 17:55:08]

nit: I think the convention is to first check HasSwitch (here and below).

[servolk, 2016/07/28 21:46:46]

This comment seems to imply that it's unnecessary:
https://cs.chromium.org/chromium/src/base/command_line.h?rcl=1469719166&l=166

[wolenetz, 2016/07/28 23:02:15]

Acknowledged.

+          base::CommandLine::ForCurrentProcess()->GetSwitchValueASCII(
+              switches::kMSEAudioBufferSize);
+      unsigned mseAudioBufferSize = 0;
+      if (base::StringToUint(audioBufferSwitchStr, &mseAudioBufferSize) &&
+          mseAudioBufferSize > 0) {
+        audio_->SetStreamMemoryLimit(mseAudioBufferSize);

[wolenetz, 2016/07/28 17:55:08]

nit: Please add a MEDIA_LOG either here, or perhaps in SourceBufferStream to log
the actual memory limit that was set.

(Ditto for the video_ limit, below).

[servolk, 2016/07/28 21:46:46]

Done.

+      }
+
       if (!frame_processor_->AddTrack(FrameProcessor::kAudioTrackId, audio_)) {
         DVLOG(1) << "Failed to add audio track to frame processor.";
         return false;
       }
     }
 
     frame_processor_->OnPossibleAudioConfigUpdate(audio_config);
     success &= audio_->UpdateAudioConfig(audio_config, media_log_);
   }
 
   if (video_config.IsValidConfig()) {
     if (!video_) {
       media_log_->SetBooleanProperty("found_video_stream", true);
     }
     if (!video_ ||
         video_->video_decoder_config().codec() != video_config.codec()) {
       media_log_->SetStringProperty("video_codec_name",
                                     GetCodecName(video_config.codec()));
     }
 
     if (!video_) {
       video_ = create_demuxer_stream_cb_.Run(DemuxerStream::VIDEO);
 
       if (!video_) {
         DVLOG(1) << "Failed to create a video stream.";
         return false;
       }
 
+      std::string videoBufferSwitchStr =
+          base::CommandLine::ForCurrentProcess()->GetSwitchValueASCII(
+              switches::kMSEVideoBufferSize);
+      unsigned mseVideoBufferSize = 0;
+      if (base::StringToUint(videoBufferSwitchStr, &mseVideoBufferSize) &&
+          mseVideoBufferSize > 0) {
+        video_->SetStreamMemoryLimit(mseVideoBufferSize);
+      }
+
       if (!frame_processor_->AddTrack(FrameProcessor::kVideoTrackId, video_)) {
         DVLOG(1) << "Failed to add video track to frame processor.";
         return false;
       }
     }
 
     success &= video_->UpdateVideoConfig(video_config, media_log_);
   }
 
   typedef StreamParser::TextTrackConfigMap::const_iterator TextConfigItr;
@@ skipping 170 matching lines @@
 
 void MediaSourceState::OnSourceInitDone(
     const StreamParser::InitParameters& params) {
   DCHECK_EQ(state_, PENDING_PARSER_INIT);
   state_ = PARSER_INITIALIZED;
   auto_update_timestamp_offset_ = params.auto_update_timestamp_offset;
   base::ResetAndReturn(&init_cb_).Run(params);
 }
 
 }  // namespace media