ui/gl/gl_gl_api_implementation.cc - Issue 2170293002: Use GLVersionInfo instead of gl::GetGLImplementation() to decide GL paths

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/gl/gl_gl_api_implementation.cc

Issue 2170293002: Use GLVersionInfo instead of gl::GetGLImplementation() to decide GL paths (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add comment Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/gl/gl_gl_api_implementation.cc

diff --git a/ui/gl/gl_gl_api_implementation.cc b/ui/gl/gl_gl_api_implementation.cc

index cb12bcc685a2375b804a317607b6c7193b7dd1aa..033a129f55883edf4993d6c63d685dafff1ffb98 100644

--- a/ui/gl/gl_gl_api_implementation.cc

+++ b/ui/gl/gl_gl_api_implementation.cc

@@ -217,7 +217,7 @@ static inline GLenum GetTexFormat(GLenum format) {

}

static inline GLenum GetTexType(GLenum type) {

- if (GetGLImplementation() != kGLImplementationEGLGLES2) {

+ if (!g_version_info->is_es) {

if (type == GL_HALF_FLOAT_OES)

return GL_HALF_FLOAT_ARB;

}

« no previous file with comments | « ui/gl/gl_fence.cc ('k') | ui/gl/test/gl_image_test_template.h » ('j') | no next file with comments »