gpu/perftests/texture_upload_perftest.cc - Issue 2170293002: Use GLVersionInfo instead of gl::GetGLImplementation() to decide GL paths

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/perftests/texture_upload_perftest.cc

Issue 2170293002: Use GLVersionInfo instead of gl::GetGLImplementation() to decide GL paths (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add comment Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: gpu/perftests/texture_upload_perftest.cc

diff --git a/gpu/perftests/texture_upload_perftest.cc b/gpu/perftests/texture_upload_perftest.cc

index abb2217826e8c95276e9977fa9514e147892f53c..286bd1f8dfd3ac64992ef9e68d068cc652a953e6 100644

--- a/gpu/perftests/texture_upload_perftest.cc

+++ b/gpu/perftests/texture_upload_perftest.cc

@@ -222,7 +222,7 @@ class TextureUploadPerfTest : public testing::Test {

// used to draw a quad on the offscreen surface.

vertex_shader_ = LoadShader(GL_VERTEX_SHADER, kVertexShader);

- bool is_gles = gl::GetGLImplementation() == gl::kGLImplementationEGLGLES2;

+ bool is_gles = gl_context_->GetVersionInfo()->is_es;

fragment_shader_ = LoadShader(

GL_FRAGMENT_SHADER,

base::StringPrintf("%s%s", is_gles ? kShaderDefaultFloatPrecision : "",

« no previous file with comments | « gpu/command_buffer/service/test_helper.cc ('k') | ui/gl/gl_context_cgl.cc » ('j') | no next file with comments »