Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1036)

Unified Diff: gpu/command_buffer/service/buffer_manager.cc

Issue 2170293002: Use GLVersionInfo instead of gl::GetGLImplementation() to decide GL paths (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add comment Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | gpu/command_buffer/service/gles2_cmd_copy_texture_chromium.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/service/buffer_manager.cc
diff --git a/gpu/command_buffer/service/buffer_manager.cc b/gpu/command_buffer/service/buffer_manager.cc
index a53b93f679d9689c34238c58013543099bca76d6..891458cc6fca26d5c7892937aef210039bc37065 100644
--- a/gpu/command_buffer/service/buffer_manager.cc
+++ b/gpu/command_buffer/service/buffer_manager.cc
@@ -21,7 +21,6 @@
#include "gpu/command_buffer/service/memory_tracking.h"
#include "gpu/command_buffer/service/transform_feedback_manager.h"
#include "ui/gl/gl_bindings.h"
-#include "ui/gl/gl_implementation.h"
#include "ui/gl/gl_version_info.h"
#include "ui/gl/trace_util.h"
@@ -359,8 +358,9 @@ bool BufferManager::UseNonZeroSizeForClientSideArrayBuffer() {
bool BufferManager::UseShadowBuffer(GLenum target, GLenum usage) {
const bool is_client_side_array = IsUsageClientSideArray(usage);
+ // feature_info_ can be null in some unit tests.
const bool support_fixed_attribs =
- gl::GetGLImplementation() == gl::kGLImplementationEGLGLES2;
+ !feature_info_ || feature_info_->gl_version_info().is_es;
// TODO(zmo): Don't shadow buffer data on ES3. crbug.com/491002.
return (
« no previous file with comments | « no previous file | gpu/command_buffer/service/gles2_cmd_copy_texture_chromium.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698