Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 2170273002: Convert editing/deleting/delete-block-content-00[123].html to use w3c test harness (Closed)

Created:
4 years, 5 months ago by yosin_UTC9
Modified:
4 years, 5 months ago
Reviewers:
yoichio
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert editing/deleting/delete-block-content-00[123].html to use w3c test harness This patch converts "editing/deleting/delete-block-content-00[123].html" to use w3c test harness to simplify test files by consolidating them into "delete-block-content.html". Note: "delete-block-content-003.html" is identical to "delete-block-content-002.html" expect for 003.html has two DIV[id=root]. This patch is a preparation of getting rid of grammar checking feature. BUG=619452 TEST=n/a; this patch changes a test file Committed: https://crrev.com/08ee869813b4b05d9bad1d84b15d148891df2d58 Cr-Commit-Position: refs/heads/master@{#407087}

Patch Set 1 : 2016-07-22T11:11:22 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -289 lines) Patch
A third_party/WebKit/LayoutTests/editing/deleting/delete-block-contents.html View 1 chunk +21 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/deleting/delete-block-contents-001.html View 1 chunk +0 lines, -34 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/deleting/delete-block-contents-002.html View 1 chunk +0 lines, -36 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/deleting/delete-block-contents-003.html View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/deleting/delete-block-contents-001-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/deleting/delete-block-contents-001-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/deleting/delete-block-contents-002-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/deleting/delete-block-contents-002-expected.txt View 1 chunk +0 lines, -21 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/deleting/delete-block-contents-003-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/deleting/delete-block-contents-003-expected.txt View 1 chunk +0 lines, -28 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/deleting/delete-block-contents-001-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/deleting/delete-block-contents-001-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/deleting/delete-block-contents-002-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/deleting/delete-block-contents-002-expected.txt View 1 chunk +0 lines, -21 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/deleting/delete-block-contents-003-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/deleting/delete-block-contents-003-expected.txt View 1 chunk +0 lines, -28 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/deleting/delete-block-contents-001-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/deleting/delete-block-contents-001-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/deleting/delete-block-contents-002-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/deleting/delete-block-contents-002-expected.txt View 1 chunk +0 lines, -21 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/deleting/delete-block-contents-003-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/deleting/delete-block-contents-003-expected.txt View 1 chunk +0 lines, -28 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
yosin_UTC9
PTAL
4 years, 5 months ago (2016-07-22 04:25:55 UTC) #8
yoichio
lgtm
4 years, 5 months ago (2016-07-22 06:36:27 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2170273002/1
4 years, 5 months ago (2016-07-22 06:45:04 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-22 06:50:06 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 06:52:09 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/08ee869813b4b05d9bad1d84b15d148891df2d58
Cr-Commit-Position: refs/heads/master@{#407087}

Powered by Google App Engine
This is Rietveld 408576698