third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.h - Issue 2170263002: [DevTools] Pass error object when reporting exceptions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.h

Issue 2170263002: [DevTools] Pass error object when reporting exceptions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: typo Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp ('K') | « third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.h

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.h b/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.h

index 9662ba9a7c4db6505b706e48a342a20b01f94a37..32ef9c77baaedbd9b49bee8c1348313cf5e580d8 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.h

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.h

@@ -37,13 +37,14 @@ public:

static std::unique_ptr<V8ConsoleMessage> createForException(

double timestamp,

- const String16& message,

+ const String16& detailedMessage,

const String16& url,

unsigned lineNumber,

unsigned columnNumber,

std::unique_ptr<V8StackTraceImpl>,

int scriptId,

v8::Isolate*,

+ const String16& message,

int contextId,

v8::Local<v8::Value> exception,

unsigned exceptionId);

@@ -80,6 +81,7 @@ private:

unsigned m_exceptionId;

unsigned m_revokedExceptionId;

Arguments m_arguments;

+ String16 m_detailedMessage;

};

class V8ConsoleMessageStorage {