Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Unified Diff: third_party/WebKit/Source/core/workers/WorkerThreadTestHelper.h

Issue 2170263002: [DevTools] Pass error object when reporting exceptions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: typo Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/workers/WorkerThreadTestHelper.h
diff --git a/third_party/WebKit/Source/core/workers/WorkerThreadTestHelper.h b/third_party/WebKit/Source/core/workers/WorkerThreadTestHelper.h
index 3b48da656fde80d1a204b0b0c60bb682260b3968..eed6995bb8abbf635c184c6b32ace261379580a2 100644
--- a/third_party/WebKit/Source/core/workers/WorkerThreadTestHelper.h
+++ b/third_party/WebKit/Source/core/workers/WorkerThreadTestHelper.h
@@ -54,10 +54,10 @@ public:
MockWorkerReportingProxy() { }
~MockWorkerReportingProxy() override { }
- MOCK_METHOD2(reportExceptionMock, void(const String& errorMessage, SourceLocation*));
- void reportException(const String& errorMessage, std::unique_ptr<SourceLocation> location)
+ MOCK_METHOD2(reportExceptionMock, void(const String& errorMessage, SourceLocation*, int exceptionId));
+ void reportException(const String& errorMessage, std::unique_ptr<SourceLocation> location, int exceptionId)
{
- reportExceptionMock(errorMessage, location.get());
+ reportExceptionMock(errorMessage, location.get(), exceptionId);
}
MOCK_METHOD1(reportConsoleMessage, void(ConsoleMessage*));
MOCK_METHOD1(postMessageToPageInspector, void(const String&));
@@ -163,7 +163,7 @@ public:
return EventTargetNames::DedicatedWorkerGlobalScope;
}
- void exceptionThrown(const String&, std::unique_ptr<SourceLocation>) override
+ void exceptionThrown(ErrorEvent*) override
{
}

Powered by Google App Engine
This is Rietveld 408576698