Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Unified Diff: third_party/WebKit/Source/core/workers/SharedWorkerGlobalScope.cpp

Issue 2170263002: [DevTools] Pass error object when reporting exceptions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: typo Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/workers/SharedWorkerGlobalScope.cpp
diff --git a/third_party/WebKit/Source/core/workers/SharedWorkerGlobalScope.cpp b/third_party/WebKit/Source/core/workers/SharedWorkerGlobalScope.cpp
index ecbb0feebcc2c41fb25dcecb22534aa6a7088a27..6ddaf01062d2a520e75ba4ee61c9519870912fc3 100644
--- a/third_party/WebKit/Source/core/workers/SharedWorkerGlobalScope.cpp
+++ b/third_party/WebKit/Source/core/workers/SharedWorkerGlobalScope.cpp
@@ -84,11 +84,11 @@ SharedWorkerThread* SharedWorkerGlobalScope::thread()
return static_cast<SharedWorkerThread*>(Base::thread());
}
-void SharedWorkerGlobalScope::exceptionThrown(const String& errorMessage, std::unique_ptr<SourceLocation> location)
+void SharedWorkerGlobalScope::exceptionThrown(ErrorEvent* event)
{
- WorkerGlobalScope::exceptionThrown(errorMessage, location->clone());
+ WorkerGlobalScope::exceptionThrown(event);
if (WorkerThreadDebugger* debugger = WorkerThreadDebugger::from(thread()->isolate()))
- debugger->exceptionThrown(errorMessage, std::move(location));
+ debugger->exceptionThrown(event);
}
DEFINE_TRACE(SharedWorkerGlobalScope)

Powered by Google App Engine
This is Rietveld 408576698