Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js

Issue 2170263002: [DevTools] Pass error object when reporting exceptions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: typo Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 359 matching lines...) Expand 10 before | Expand all | Expand 10 after
370 var consoleMessage = new WebInspector.ConsoleMessage( 370 var consoleMessage = new WebInspector.ConsoleMessage(
371 this._runtimeModel.target(), 371 this._runtimeModel.target(),
372 WebInspector.ConsoleMessage.MessageSource.JS, 372 WebInspector.ConsoleMessage.MessageSource.JS,
373 WebInspector.ConsoleMessage.MessageLevel.Error, 373 WebInspector.ConsoleMessage.MessageLevel.Error,
374 details.text, 374 details.text,
375 undefined, 375 undefined,
376 details.url, 376 details.url,
377 details.lineNumber, 377 details.lineNumber,
378 details.columnNumber, 378 details.columnNumber,
379 undefined, 379 undefined,
380 exception ? ["Uncaught (in promise)", exception] : undefined, 380 exception ? [WebInspector.RemoteObject.fromLocalObject(details.text) , exception] : undefined,
381 details.stackTrace, 381 details.stackTrace,
382 timestamp, 382 timestamp,
383 executionContextId, 383 executionContextId,
384 details.scriptId); 384 details.scriptId);
385 consoleMessage.setExceptionId(exceptionId); 385 consoleMessage.setExceptionId(exceptionId);
386 this._runtimeModel.target().consoleModel.addMessage(consoleMessage); 386 this._runtimeModel.target().consoleModel.addMessage(consoleMessage);
387 }, 387 },
388 388
389 /** 389 /**
390 * @override 390 * @override
(...skipping 619 matching lines...) Expand 10 before | Expand all | Expand 10 after
1010 /** 1010 /**
1011 * @return {boolean} 1011 * @return {boolean}
1012 */ 1012 */
1013 isNormalListenerType: function() 1013 isNormalListenerType: function()
1014 { 1014 {
1015 return this._listenerType === "normal"; 1015 return this._listenerType === "normal";
1016 }, 1016 },
1017 1017
1018 __proto__: WebInspector.SDKObject.prototype 1018 __proto__: WebInspector.SDKObject.prototype
1019 } 1019 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698