Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 2170233002: Revert of Default enable main frame before activation and remove finch experiment. (Closed)

Created:
4 years, 5 months ago by Ted C
Modified:
4 years, 5 months ago
Reviewers:
sunnyps, rkaplow, piman
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org, brianderson
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Default enable main frame before activation and remove finch experiment. (patchset #1 id:1 of https://codereview.chromium.org/2159103008/ ) Reason for revert: Speculative revert for failing WebView tests on Lollipop: https://build.chromium.org/p/chromium.android/builders/Lollipop%20Phone%20Tester/builds/5794 https://build.chromium.org/p/chromium.android/builders/Lollipop%20Tablet%20Tester/builds/4054 Both phone and tablet started failing and this is the most "suspicious" change. boliu@ can help investigate further assuming this holds true. Original issue's description: > Default enable main frame before activation and remove finch experiment. > > The finch experiment hasn't revealed any regressions other than in page > load times which has been deemed a blink scheduler issue (see > crbug.com/614482). > > R=piman@chromium.org,rkaplow@chromium.org > BUG=612596 > > Committed: https://crrev.com/45041a7e286c665ab14d8ae0b182e1c11cef65ed > Cr-Commit-Position: refs/heads/master@{#406916} TBR=piman@chromium.org,rkaplow@chromium.org,sunnyps@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=612596 Committed: https://crrev.com/2863590ee8e57543f646f4308130765afb02bd44 Cr-Commit-Position: refs/heads/master@{#407003}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -1 line) Patch
M content/browser/gpu/compositor_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/common/content_features.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_features.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_android.json View 1 chunk +8 lines, -0 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_chromeos.json View 1 chunk +8 lines, -0 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_linux.json View 1 chunk +8 lines, -0 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_mac.json View 1 chunk +8 lines, -0 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_win.json View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Ted C
Created Revert of Default enable main frame before activation and remove finch experiment.
4 years, 5 months ago (2016-07-22 00:53:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2170233002/1
4 years, 5 months ago (2016-07-22 00:54:26 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-22 00:55:17 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2863590ee8e57543f646f4308130765afb02bd44 Cr-Commit-Position: refs/heads/master@{#407003}
4 years, 5 months ago (2016-07-22 00:57:20 UTC) #7
sunnyps
4 years, 4 months ago (2016-07-28 01:56:11 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2184243003/ by sunnyps@chromium.org.

The reason for reverting is: Relanding after fixing android webview issues.

Powered by Google App Engine
This is Rietveld 408576698