LayoutTests/fast/serviceworker/access-container-with-invalid-context-expected.txt - Issue 217023003: Add null checks in navigator.serviceWorker access to fix possible crash

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/serviceworker/access-container-with-invalid-context-expected.txt

Issue 217023003: Add null checks in navigator.serviceWorker access to fix possible crash (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/serviceworker/access-container-with-invalid-context.html ('K') | « LayoutTests/fast/serviceworker/access-container-with-invalid-context.html ('k') | Source/modules/serviceworkers/NavigatorServiceWorker.cpp » ('j') | Source/modules/serviceworkers/ServiceWorkerContainer.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/serviceworker/access-container-with-invalid-context-expected.txt

diff --git a/LayoutTests/accessibility/crashing-a-tag-in-map-expected.txt b/LayoutTests/fast/serviceworker/access-container-with-invalid-context-expected.txt

similarity index 59%

copy from LayoutTests/accessibility/crashing-a-tag-in-map-expected.txt

copy to LayoutTests/fast/serviceworker/access-container-with-invalid-context-expected.txt

index e2e890293aacc72d81b628dabd8771ae4e3a465f..c15bb057c7baa355f96e4dec05dbe02dad5854b9 100644

--- a/LayoutTests/accessibility/crashing-a-tag-in-map-expected.txt

+++ b/LayoutTests/fast/serviceworker/access-container-with-invalid-context-expected.txt

@@ -1,5 +1,4 @@

-This tests that a hit test on a image map that has areas and anchors does not crash

+This test checks if accessing navigator.serviceWorker doesn't fail with invalid frame

On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".

@@ -7,4 +6,5 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE

PASS successfullyParsed is true

TEST COMPLETE

+DONE