LayoutTests/fast/serviceworker/access-container-with-invalid-context.html - Issue 217023003: Add null checks in navigator.serviceWorker access to fix possible crash

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/serviceworker/access-container-with-invalid-context.html

Issue 217023003: Add null checks in navigator.serviceWorker access to fix possible crash (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: reverted iframe change Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <div id="container"></div>

	3 <script src="../../resources/testharness.js"></script>

	4 <script src="../../resources/testharnessreport.js"></script>

	5 <script>

	6 var test = async_test("This test checks if accessing navigator.serviceWorker doe sn't crash with invalid frame");

	7

	8 if (testRunner)

	9 testRunner.setCanOpenWindows();

	10

	11 function callback() {

	12 // At this time window.navigator may be replaced with a new iframe's one,

	13 // which could be now invalid.

	14 var sw = navigator.serviceWorker;

	15 test.done();

	16 }

	17

	18 test.step(function() {

	19 var w = window.open("x", "y");

	20 window.navigator = w.navigator;

	21 setTimeout(callback, 1);

	22 });

	23 </script>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/serviceworker/access-container-with-invalid-context-expected.txt » ('j') | no next file with comments »