Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Issue 2170223002: [MD settings] close the side nav when navigating back/forward (Closed)

Created:
4 years, 5 months ago by dschuyler
Modified:
4 years, 5 months ago
Reviewers:
tommycli
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] close the side nav when navigating back/forward This CL solves a problem with the side nav menu drawer staying open when using the back/forward buttons. The drawer now closes when navigating forward or back. BUG=623903 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/f2e8191e41dae27a051bc54271fbd971db1bfafd Cr-Commit-Position: refs/heads/master@{#407290}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -7 lines) Patch
M chrome/browser/resources/settings/settings_ui/settings_ui.js View 2 chunks +11 lines, -7 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
dschuyler
I moved the ready function to match the order described in our style guide: https://docs.google.com/document/d/1G0t519y_cSW4etXVwruR145abZH0N5-9R7JyejzVoTs/edit
4 years, 5 months ago (2016-07-22 00:49:02 UTC) #5
tommycli
lgtm thanks
4 years, 5 months ago (2016-07-22 22:37:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2170223002/1
4 years, 5 months ago (2016-07-22 22:51:04 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-22 22:55:31 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 22:56:50 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f2e8191e41dae27a051bc54271fbd971db1bfafd
Cr-Commit-Position: refs/heads/master@{#407290}

Powered by Google App Engine
This is Rietveld 408576698