Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2170203002: [Android] Include XML resources in when building chrome apk (Closed)

Created:
4 years, 5 months ago by Ian Wen
Modified:
4 years, 5 months ago
Reviewers:
gone
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Include XML resources in when building chrome apk Chrome has been suffering from not being able to use xml values in the support library for a while. This CL fixes it by making chrome_java_resources and android_tools connected. BUG=622941 Committed: https://crrev.com/78c9be6e827c775f4457b25c2e81b036a09fa5b9 Cr-Commit-Position: refs/heads/master@{#407041}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/android/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Ian Wen
4 years, 5 months ago (2016-07-22 00:41:06 UTC) #2
gone
lgtm
4 years, 5 months ago (2016-07-22 00:45:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2170203002/1
4 years, 5 months ago (2016-07-22 00:47:44 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-22 03:45:23 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 03:48:14 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/78c9be6e827c775f4457b25c2e81b036a09fa5b9
Cr-Commit-Position: refs/heads/master@{#407041}

Powered by Google App Engine
This is Rietveld 408576698