Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2170163002: Add mb config for chromium.chromedriver. (Closed)

Created:
4 years, 5 months ago by samuong
Modified:
4 years, 5 months ago
Reviewers:
Dirk Pranke, jbudorick
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add mb config for chromium.chromedriver. BUG=chromedriver:1384 Committed: https://crrev.com/a2ff7b4f84bc168eb6f5fc2b5758cabf49876184 Cr-Commit-Position: refs/heads/master@{#407065}

Patch Set 1 #

Total comments: 2

Patch Set 2 : use gn_release_bot and gn_release_bot_x86 instead #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M tools/mb/mb_config.pyl View 1 1 chunk +7 lines, -0 lines 2 comments Download

Messages

Total messages: 14 (4 generated)
samuong
John, does this look right to you? samuong@samuong1:~/chromium/src$ tools/mb/mb.py gen -b Linux -m chromium.chromedriver -nv ...
4 years, 5 months ago (2016-07-21 23:33:00 UTC) #2
jbudorick
https://codereview.chromium.org/2170163002/diff/1/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (right): https://codereview.chromium.org/2170163002/diff/1/tools/mb/mb_config.pyl#newcode1144 tools/mb/mb_config.pyl:1144: 'gn_goma_release_static': [ I think these are equivalent to gn_release_bot ...
4 years, 5 months ago (2016-07-22 00:47:31 UTC) #3
samuong
https://codereview.chromium.org/2170163002/diff/1/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (right): https://codereview.chromium.org/2170163002/diff/1/tools/mb/mb_config.pyl#newcode1144 tools/mb/mb_config.pyl:1144: 'gn_goma_release_static': [ On 2016/07/22 00:47:31, jbudorick wrote: > I ...
4 years, 5 months ago (2016-07-22 02:08:46 UTC) #4
jbudorick
lgtm, not an owner
4 years, 5 months ago (2016-07-22 02:19:44 UTC) #5
samuong
This is the first of two CLs, which convert the ChromeDriver bots over to GN. ...
4 years, 5 months ago (2016-07-22 02:50:34 UTC) #7
Dirk Pranke
lgtm w/ a question ... https://codereview.chromium.org/2170163002/diff/20001/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (right): https://codereview.chromium.org/2170163002/diff/20001/tools/mb/mb_config.pyl#newcode76 tools/mb/mb_config.pyl:76: 'Linux32': 'gn_release_bot_x86', Do you ...
4 years, 5 months ago (2016-07-22 03:11:46 UTC) #8
samuong
https://codereview.chromium.org/2170163002/diff/20001/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (right): https://codereview.chromium.org/2170163002/diff/20001/tools/mb/mb_config.pyl#newcode76 tools/mb/mb_config.pyl:76: 'Linux32': 'gn_release_bot_x86', On 2016/07/22 03:11:46, Dirk Pranke wrote: > ...
4 years, 5 months ago (2016-07-22 03:46:27 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2170163002/20001
4 years, 5 months ago (2016-07-22 03:47:07 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-22 05:12:52 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 05:14:25 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a2ff7b4f84bc168eb6f5fc2b5758cabf49876184
Cr-Commit-Position: refs/heads/master@{#407065}

Powered by Google App Engine
This is Rietveld 408576698