Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2170153002:
Suppress two GLES2 conformance failures on Mac NVIDIA. (Closed)
|
Created:
4 years, 5 months ago by Ken Russell (switch to Gerrit) Modified:
4 years, 5 months ago CC:
chromium-reviews, piman+watch_chromium.org, Corentin Wallez, Jamie Madill, Geoff Lang, eyaich1 Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionSuppress two GLES2 conformance failures on Mac NVIDIA.
BUG=630452
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
R=zmo@chromium.org
TBR=piman@chromium.org
NOTRY=true
Committed: https://crrev.com/73bf375290c8ac2a8ebb834319c515756a667ae9
Cr-Commit-Position: refs/heads/master@{#406997}
Patch Set 1 #
Messages
Total messages: 22 (10 generated)
Description was changed from ========== Suppress two GLES2 conformance failures on Mac NVIDIA. BUG=630452 ========== to ========== Suppress two GLES2 conformance failures on Mac NVIDIA. BUG=630452 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
kbr@chromium.org changed reviewers: + zmo@chromium.org
Mo: please review. Thanks. Others: FYI.
Note: tested locally on Linux. The conformance expectations still parse correctly there.
lgtm
CQ'ing TBR'd and NOTRY to get the bots greener sooner.
Description was changed from ========== Suppress two GLES2 conformance failures on Mac NVIDIA. BUG=630452 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Suppress two GLES2 conformance failures on Mac NVIDIA. BUG=630452 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel R=zmo@chromium.org NOTRY=true ==========
On 2016/07/21 23:31:46, Ken Russell wrote: > CQ'ing TBR'd and NOTRY to get the bots greener sooner. Sorry, I meant just NOTRY.
The CQ bit was checked by kbr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
Description was changed from ========== Suppress two GLES2 conformance failures on Mac NVIDIA. BUG=630452 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel R=zmo@chromium.org NOTRY=true ========== to ========== Suppress two GLES2 conformance failures on Mac NVIDIA. BUG=630452 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel R=zmo@chromium.org TBR=piman@chromium.org NOTRY=true ==========
kbr@chromium.org changed reviewers: + piman@chromium.org
TBR= to piman
The CQ bit was checked by kbr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Suppress two GLES2 conformance failures on Mac NVIDIA. BUG=630452 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel R=zmo@chromium.org TBR=piman@chromium.org NOTRY=true ========== to ========== Suppress two GLES2 conformance failures on Mac NVIDIA. BUG=630452 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel R=zmo@chromium.org TBR=piman@chromium.org NOTRY=true ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Suppress two GLES2 conformance failures on Mac NVIDIA. BUG=630452 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel R=zmo@chromium.org TBR=piman@chromium.org NOTRY=true ========== to ========== Suppress two GLES2 conformance failures on Mac NVIDIA. BUG=630452 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel R=zmo@chromium.org TBR=piman@chromium.org NOTRY=true Committed: https://crrev.com/73bf375290c8ac2a8ebb834319c515756a667ae9 Cr-Commit-Position: refs/heads/master@{#406997} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/73bf375290c8ac2a8ebb834319c515756a667ae9 Cr-Commit-Position: refs/heads/master@{#406997}
Message was sent while issue was closed.
lgtm |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
