Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 2170133003: Revert of Reland: H264 HW encode using MediaFoundation (Closed)

Created:
4 years, 5 months ago by emircan
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews, posciak+watch_chromium.org, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Reland: H264 HW encode using MediaFoundation (patchset #2 id:20001 of https://codereview.chromium.org/2167333002/ ) Reason for revert: Build errors on this bot: https://build.chromium.org/p/chromium/builders/Win%20x64/builds/2630/steps/compile/logs/stdio Original issue's description: > Reland: H264 HW encode using MediaFoundation > > Got reverted due to breaking MSVC build: > https://bugs.chromium.org/p/chromium/issues/detail?id=630335#c2 > > This CL moves GTEST_FAIL() lines so that they fail at the end of the > function. > > Original description ---------------------------------------------- > > H264 HW encode using MediaFoundation > > This CL adds MediaFoundationVideoEncodeAccelerator which enables H264 encode support > using MediaFoundation on Windows 8.1+. Also, it includes a refactor of common > MediaFoundation classes under mf_helpers.*. > > Note that, this is the first CL and H264 codec is still behind a flag. > > Design Doc(with perf measurements): http://goo.gl/UCnwyA > > BUG=590060 > TEST= Tested AppRTC loopback with Chrome flag "--enable-webrtc-hw-h264-encoding" and > "--enable-mf-h264-encoding" on https://apprtc.appspot.com/?debug=loopback&vsc=h264 > Also, added WIN specific sections at vea_unittests. > > TBR=ananta@chromium.org,avi@chromium.org,grt@chromium.org,sandersd@chromium.org,wuchengli@chromium.org > The incremented change is trivial. > > Committed: https://crrev.com/aa60bafce8cb29062030362aaa7c321350b67f84 > Cr-Commit-Position: refs/heads/master@{#407049} TBR= # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=590060 Committed: https://crrev.com/f1213cf3c95ce361ec4e655408828e2026def933 Cr-Commit-Position: refs/heads/master@{#407063}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -983 lines) Patch
M content/browser/gpu/gpu_process_host.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/gpu/gpu_main.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M media/base/media_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M media/base/media_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M media/base/win/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D media/base/win/mf_helpers.h View 1 chunk +0 lines, -77 lines 0 comments Download
D media/base/win/mf_helpers.cc View 1 chunk +0 lines, -57 lines 0 comments Download
M media/gpu/BUILD.gn View 3 chunks +2 lines, -7 lines 0 comments Download
M media/gpu/dxva_video_decode_accelerator_win.cc View 6 chunks +101 lines, -3 lines 0 comments Download
M media/gpu/ipc/service/gpu_video_encode_accelerator.h View 1 chunk +0 lines, -4 lines 0 comments Download
M media/gpu/ipc/service/gpu_video_encode_accelerator.cc View 3 chunks +0 lines, -19 lines 0 comments Download
D media/gpu/media_foundation_video_encode_accelerator_win.h View 1 chunk +0 lines, -147 lines 0 comments Download
D media/gpu/media_foundation_video_encode_accelerator_win.cc View 1 chunk +0 lines, -562 lines 0 comments Download
M media/gpu/video_encode_accelerator_unittest.cc View 22 chunks +26 lines, -87 lines 0 comments Download
M media/media.gyp View 3 chunks +1 line, -8 lines 0 comments Download
M media/media_gpu.gypi View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
emircan
Created Revert of Reland: H264 HW encode using MediaFoundation
4 years, 5 months ago (2016-07-22 05:00:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2170133003/1
4 years, 5 months ago (2016-07-22 05:01:31 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-22 05:02:38 UTC) #4
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 05:04:11 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f1213cf3c95ce361ec4e655408828e2026def933
Cr-Commit-Position: refs/heads/master@{#407063}

Powered by Google App Engine
This is Rietveld 408576698