Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 217013005: Replace WebKitShadowRoot constructor with ShadowRoot constructor. (Closed)

Created:
6 years, 8 months ago by hayato
Modified:
6 years, 8 months ago
Reviewers:
stgao
CC:
chromium-reviews, stgao, dglazkov, esprehn
Visibility:
Public.

Description

Replace WebKitShadowRoot constructor with ShadowRoot constructor. Don't use deprecated WebKitShadowRoot constructor. BUG=242153 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260505

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/test/chromedriver/js/call_function.js View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
hayato
PTAL. Looks like this patch needs LGTM from chrome/test/chromedriver/OWNERS.
6 years, 8 months ago (2014-03-31 05:43:39 UTC) #1
stgao
lgtm
6 years, 8 months ago (2014-03-31 06:27:47 UTC) #2
hayato
The CQ bit was checked by hayato@chromium.org
6 years, 8 months ago (2014-03-31 06:35:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hayato@chromium.org/217013005/1
6 years, 8 months ago (2014-03-31 06:36:02 UTC) #4
commit-bot: I haz the power
6 years, 8 months ago (2014-03-31 08:35:57 UTC) #5
Message was sent while issue was closed.
Change committed as 260505

Powered by Google App Engine
This is Rietveld 408576698