Issue 217013002: Revert r20335 - "Raise StackOverflow during bootstrapping"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 217013002: Revert r20335 - "Raise StackOverflow during bootstrapping" (Closed)

Created:
6 years, 9 months ago by jochen (gone - plz use gerrit)

Modified:
6 years, 9 months ago

Reviewers:
Jarin

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Revert r20335 - "Raise StackOverflow during bootstrapping" Reason for revert: New test crashes on nosnap bots > See https://github.com/joyent/node/issues/7120 > > R=jarin@chromium.org > BUG= > > Review URL: https://codereview.chromium.org/178073002 > > Patch from Alexis Campailla <alexis@janeasystems.com>;. TBR=jarin@chromium.org BUG=none LOG=n Committed: https://code.google.com/p/v8/source/detail?r=20337

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -75 lines)			Patch
M	src/bootstrapper.cc	View	2 chunks	+6 lines, -9 lines	0 comments	Download
M	src/isolate.h	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	test/cctest/test-api.cc	View	1 chunk	+0 lines, -61 lines	0 comments	Download

Total messages: 3 (0 generated)

jochen (gone - plz use gerrit)

Committed patchset #1 manually as r20337 (tree was closed).

6 years, 9 months ago (2014-03-28 14:16:18 UTC) #2

Jarin

6 years, 9 months ago (2014-03-28 14:52:22 UTC) #3

Message was sent while issue was closed.

On 2014/03/28 14:16:18, jochen wrote:
> Committed patchset #1 manually as r20337 (tree was closed).

lgtm. thanks.