Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 2170123003: Fix typo in printing.gyp (Closed)

Created:
4 years, 5 months ago by skau
Modified:
4 years, 5 months ago
Reviewers:
Lei Zhang, emircan
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix GYP build for Chrome OS to match GN Fix type in printing.gyp: printing/backend/cups_deleter{,s}.{h,cc} Disable the cloud print connector like in GN in chrome.gyp BUG=630791 TEST=Ran `GYP_CHROMIUM_NO_ACTION=0 gclient sync` and verified that chrome compiles Committed: https://crrev.com/d9e819815d379eb2492514ddb8158def89314311 Cr-Commit-Position: refs/heads/master@{#407317}

Patch Set 1 #

Patch Set 2 : GYP file typo #

Patch Set 3 : \ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -13 lines) Patch
M chrome/chrome.gyp View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
M printing/printing.gyp View 2 chunks +9 lines, -7 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
skau
I made some mistakes with the GYP file. This should fix it.
4 years, 5 months ago (2016-07-22 23:19:51 UTC) #4
Lei Zhang
lgtm
4 years, 5 months ago (2016-07-22 23:26:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2170123003/40001
4 years, 5 months ago (2016-07-22 23:41:34 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-23 00:30:13 UTC) #9
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/d9e819815d379eb2492514ddb8158def89314311 Cr-Commit-Position: refs/heads/master@{#407317}
4 years, 5 months ago (2016-07-23 00:31:52 UTC) #11
skau
On 2016/07/23 00:31:52, commit-bot: I haz the power wrote: > Patchset 3 (id:??) landed as ...
4 years, 5 months ago (2016-07-23 02:53:49 UTC) #12
skau
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/2173283002/ by skau@chromium.org. ...
4 years, 5 months ago (2016-07-23 02:54:24 UTC) #13
Lei Zhang
4 years, 5 months ago (2016-07-23 02:54:58 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2177733002/ by thestig@chromium.org.

The reason for reverting is: Broke "Win8 GYP (dbg)" bot.

https://build.chromium.org/p/chromium.win/builders/Win8%20GYP%20%28dbg%29/bui...

python.exe gyp-win-tool link-with-manifests environment.x86 True
initial\chrome.dll
error LNK2005: "public: static class scoped_refptr<class
cloud_print::PrintSystem> __cdecl cloud_print::PrintSystem::CreateInstance(...)

initial\chrome.dll : fatal error LNK1169: one or more multiply defined symbols
found
.

Powered by Google App Engine
This is Rietveld 408576698