Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5611)

Unified Diff: chrome/browser/chromeos/hats/hats_notification_controller.cc

Issue 2170113002: Adds a notification origin URL to solve minor bug (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Adds a notification origin URL to solve minor bug Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/hats/hats_notification_controller.cc
diff --git a/chrome/browser/chromeos/hats/hats_notification_controller.cc b/chrome/browser/chromeos/hats/hats_notification_controller.cc
index 3f9e45f197e84700867e9d42d91b37c5ed9ca8b2..878108952273348450f60da3c5abeedf55902b4f 100644
--- a/chrome/browser/chromeos/hats/hats_notification_controller.cc
+++ b/chrome/browser/chromeos/hats/hats_notification_controller.cc
@@ -28,6 +28,8 @@
namespace {
+const char kNotificationOriginUrl[] = "chrome://hats";
+
// Returns true if the given |profile| interacted with HaTS by either
// dismissing the notification or taking the survey within a given threshold
// days |threshold_days|.
@@ -96,7 +98,6 @@ void HatsNotificationController::Initialize(bool is_new_device) {
}
// static
-// TODO(malaykeshav): Add check for @google accounts.
bool HatsNotificationController::ShouldShowSurveyToProfile(Profile* profile) {
// Do not show the survey if the HaTS feature is disabled for the device. This
// flag is controlled by finch and is enabled only when the device has been
@@ -185,7 +186,7 @@ Notification* HatsNotificationController::CreateNotification() {
message_center::NotifierId(message_center::NotifierId::SYSTEM_COMPONENT,
ash::system_notifier::kNotifierHats),
l10n_util::GetStringUTF16(IDS_MESSAGE_CENTER_NOTIFIER_HATS_NAME),
- GURL() /* Send an empty invalid url */, kNotificationId, optional, this);
+ GURL(kNotificationOriginUrl), kNotificationId, optional, this);
}
void HatsNotificationController::UpdateLastInteractionTime() {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698