Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 2170113002: Adds a notification origin URL to solve minor bug (Closed)

Created:
4 years, 5 months ago by malaykeshav
Modified:
4 years, 5 months ago
Reviewers:
jdufault, stevenjb
CC:
chromium-reviews, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adds a notification origin URL to solve minor bug BUG=611781 COMPONENT=Chrome OS, HaTS Committed: https://crrev.com/d21f0f973032eb008e49bdc5f3564c862b47a77a Cr-Commit-Position: refs/heads/master@{#406990}

Patch Set 1 : Adds a notification origin URL to solve minor bug #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/browser/chromeos/hats/hats_notification_controller.cc View 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
malaykeshav
4 years, 5 months ago (2016-07-21 21:46:12 UTC) #4
jdufault
lgtm
4 years, 5 months ago (2016-07-21 21:47:29 UTC) #5
stevenjb
lgtm
4 years, 5 months ago (2016-07-21 23:01:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2170113002/20001
4 years, 5 months ago (2016-07-21 23:26:33 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 5 months ago (2016-07-21 23:34:38 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 23:36:17 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d21f0f973032eb008e49bdc5f3564c862b47a77a
Cr-Commit-Position: refs/heads/master@{#406990}

Powered by Google App Engine
This is Rietveld 408576698