Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Side by Side Diff: ATOTIC.txt

Issue 2170083002: Remove old atotic file. (Closed) Base URL: https://github.com/catapult-project/catapult.git@polymer10-rebase
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 third_party has polymer
2
3 # RUN
4
5 bin/run_dev_server
6
7 side_panel
8
9 # PLAN
10 - update third_party/polymer to 1.0
11 - update includes
12
13
14 # EXECUTE
15
16 core-collapse
17 core-icons
18 core-icon-button
19 core-item
20 core-menu
21 core-overlay
22 core-selector
23 core-overlay: is now a behavior
24 paper-dropdown is gone
25 paper-shadow is gone
26
27 dashboard/perf_insights
28
29 # GENERAL COMMENTS
30 - did not use properties, lots of unnecessary code
31 - few global property leaks, should always have closures
32 - did not use Polymer to create views, lots of imperative dom manipulation code
33 - appendChild might not work without Polymer.dom. But then, it might
34 - if property is used inside a template, it getter/setter will be generated auto matically, overriding the defined setter (tab_view.html)
35
36 # TODO
37
38 find . -name "*.html" -exec grep -H -C 0 "tr-ui-a-stacked-pane" {} \;
39 - force webcomponents shadowDom mode
40 - grep for shadowRoot everywhere
41
42 # FAILING TESTS
43 /tracing/tracing/ui/extras/about_tracing/mock_tracing_controller_client.html -- not Polymer related?
44 changeTabCausesEvent
45
46 # DIRECTORIES
47 dashboard/dashboard/elements
48 perf_insights/perf_insights/ui/generic_results_view
49 tracing/tracing/ui
50
51 ./analysis/analysis_sub_view.html:<polymer-element name="tr-ui-a-sub-view">
52 - Converted to behavior Catapult.tr_ui_a_sub_view_behavior
53
54 ./analysis/alert_sub_view.html:<polymer-element name="tr-ui-a-alert-sub-view"
55
56 ./analysis/analysis_link.html:<polymer-element name="tr-ui-a-analysis-link" is=" a"
57 - Was is="a", solved by creating anchor element inside
58 - had to add element handlers
59
60 ./analysis/analysis_view.html:<polymer-element name="tr-ui-a-analysis-view">
61 - Had chaeck with getPolymerElementNamed. Rewrote with subView.constructor === H TMLElement
62 - np
63
64 ./analysis/container_memory_dump_sub_view.html:<polymer-element name="tr-ui-a-co ntainer-memory-dump-sub-view"
65 - np
66
67 ./analysis/counter_sample_sub_view.html:<polymer-element name='tr-ui-a-counter-s ample-sub-view'
68 - np
69
70 ./analysis/frame_power_usage_chart.html:<polymer-element name="tr-ui-a-frame-pow er-usage-chart">
71 - np
72
73 ./analysis/generic_object_view.html:<polymer-element name="tr-ui-a-generic-objec t-view"
74 ./analysis/generic_object_view.html:<polymer-element name="tr-ui-a-generic-objec t-view-with-label"
75 - why tr-ui-a-generic-object-view is="HTMLUnknownElement"
76 - why tr-ui-a-generic-object-view-with-label is="HTMLUnknownElement"
77 - inside ready(), direct dom manipulation, and shadowRoot. Should let Polymer do it
78
79 ./analysis/memory_dump_allocator_details_pane.html:<polymer-element name="tr-ui- a-memory-dump-allocator-details-pane"
80 -np
81
82 ./analysis/memory_dump_header_pane.html:<polymer-element name="tr-ui-a-memory-du mp-header-pane"
83 why sole </tr-ui-b-view-specific-brushing-state>
84
85 ./analysis/memory_dump_heap_details_pane.html:<polymer-element name="tr-ui-a-mem ory-dump-heap-details-pane"
86 - np
87
88 ./analysis/memory_dump_overview_pane.html:<polymer-element name="tr-ui-a-memory- dump-overview-pane"
89 - np
90
91 ./analysis/memory_dump_vm_regions_details_pane.html:<polymer-element name="tr-ui -a-memory-dump-vm-regions-details-pane"
92 - np
93
94 ./analysis/multi_async_slice_sub_view.html:<polymer-element name="tr-ui-a-multi- async-slice-sub-view"
95 - np
96
97 ./analysis/multi_cpu_slice_sub_view.html:<polymer-element name="tr-ui-a-multi-cp u-slice-sub-view"
98 -np
99
100 ./analysis/multi_event_details_table.html:<polymer-element name='tr-ui-a-multi-e vent-details-table'>
101 -np
102
103 ./analysis/multi_event_sub_view.html:<polymer-element name="tr-ui-a-multi-event- sub-view"
104 -np
105
106 ./analysis/multi_event_summary_table.html:<polymer-element name='tr-ui-a-multi-e vent-summary-table'>
107 - spurious </script> tag, can cause problems with vulcanize
108
109 ./analysis/multi_flow_event_sub_view.html:<polymer-element name="tr-ui-a-multi-f low-event-sub-view"
110 -np
111
112 ./analysis/multi_frame_sub_view.html:<polymer-element name="tr-ui-a-multi-frame- sub-view"
113 -np
114
115 ./analysis/multi_instant_event_sub_view.html:<polymer-element name="tr-ui-a-mult i-instant-event-sub-view"
116 -np
117
118 ./analysis/multi_interaction_record_sub_view.html:<polymer-element name="tr-ui-a -multi-interaction-record-sub-view"
119 -np
120
121 ./analysis/multi_object_sub_view.html:<polymer-element name="tr-ui-a-multi-objec t-sub-view"
122 -np
123
124 ./analysis/multi_power_sample_sub_view.html:<polymer-element name="tr-ui-a-multi -power-sample-sub-view"
125 -np
126
127 ./analysis/multi_sample_sub_view.html:<polymer-element name="tr-ui-a-multi-sampl e-sub-view"
128 -np
129
130 ./analysis/multi_thread_slice_sub_view.html:<polymer-element name="tr-ui-a-multi -thread-slice-sub-view"
131 -np
132
133 ./analysis/multi_thread_time_slice_sub_view.html:<polymer-element name="tr-ui-a- multi-thread-time-slice-sub-view"
134 -np
135
136 ./analysis/power_sample_summary_table.html:<polymer-element name="tr-ui-a-power- sample-summary-table">
137 -np
138
139 ./analysis/power_sample_table.html:<polymer-element name="tr-ui-a-power-sample-t able">
140 -np
141
142 ./analysis/related_events.html:<polymer-element name="tr-ui-a-related-events">
143 -np
144
145 ./analysis/selection_summary_table.html:<polymer-element name='tr-ui-a-selection -summary-table'>
146 -np
147
148 ./analysis/single_alert_sub_view.html:<polymer-element name="tr-ui-a-single-aler t-sub-view"
149 -np
150
151 ./analysis/single_async_slice_sub_view.html:<polymer-element name="tr-ui-a-singl e-async-slice-sub-view"
152 -np
153
154 ./analysis/single_cpu_slice_sub_view.html:<polymer-element name="tr-ui-a-single- cpu-slice-sub-view"
155 -np
156
157 ./analysis/single_event_sub_view.html:<polymer-element name="tr-ui-a-single-even t-sub-view"
158 -np
159
160 ./analysis/single_flow_event_sub_view.html:<polymer-element name="tr-ui-a-single -flow-event-sub-view"
161 FIXME
162 -problematic: extends tr-ui-a-single-event-sub-view
163 tr-ui-a-single-event-sub-view has large api. All it does is override getEvent Rows
164 - solution: tr-ui-a-single-event-sub-view should have an attribute that enables getEventRows oeverraide
165 - where do these elements get created?
166
167 ./analysis/single_frame_sub_view.html:<polymer-element name="tr-ui-a-single-fram e-sub-view"
168 -np
169
170 ./analysis/single_instant_event_sub_view.html:<polymer-element name="tr-ui-a-sin gle-instant-event-sub-view"
171 -np
172
173 ./analysis/single_interaction_record_sub_view.html:<polymer-element name="tr-ui- a-single-interaction-record-sub-view"
174 -np
175
176 ./analysis/single_object_instance_sub_view.html:<polymer-element name="tr-ui-a-s ingle-object-instance-sub-view"
177 - uses innerHtml. This might not work without Polymer.dom
178
179 ./analysis/single_object_snapshot_sub_view.html:<polymer-element name="tr-ui-a-s ingle-object-snapshot-sub-view"
180 - appendChild, might not work without Polymer.dom
181
182 ./analysis/single_power_sample_sub_view.html:<polymer-element name="tr-ui-a-sing le-power-sample-sub-view"
183 - np
184
185 ./analysis/single_sample_sub_view.html:<polymer-element name="tr-ui-a-single-sam ple-sub-view"
186 -np
187
188 ./analysis/single_thread_slice_sub_view.html:<polymer-element name="tr-ui-a-sing le-thread-slice-sub-view"
189 -np
190
191 ./analysis/single_thread_time_slice_sub_view.html:<polymer-element name="tr-ui-a -single-thread-time-slice-sub-view"
192 -np
193
194 ./analysis/stack_frame.html:<polymer-element name="tr-ui-a-stack-frame">
195 -np
196
197 ./analysis/stacked_pane.html:<polymer-element name="tr-ui-a-stacked-pane">
198 - converted to behavior Catapult.tr_ui_a_stacked_pane
199
200 ./analysis/stacked_pane_view.html:<polymer-element name="tr-ui-a-stacked-pane-vi ew">
201 - np
202
203 ./analysis/tab_view.html:<polymer-element name="tr-ui-a-tab-view"
204 - has constructor, had to fake this
205 - fixed up template expressions
206 - there is a getter and a setter for selectedTab
207 ./base/color_legend.html:<polymer-element name="tr-ui-b-color-legend">
208 - np
209
210 ./base/drag_handle.html:<polymer-element name="tr-ui-b-drag-handle">
211 - FIXME: has a __proto__ HTMLDivElement. Why, and how do we fix this?
212
213 ./base/dropdown.html:<polymer-element name="tr-ui-b-dropdown">
214 - np
215
216 ./base/heading.html:<polymer-element name='tr-ui-heading'>
217 - np
218
219 ./base/hotkey_controller.html:<polymer-element name="tv-ui-b-hotkey-controller">
220 - np
221
222 ./base/info_bar.html:<polymer-element name='tr-ui-b-info-bar' is='HTMLDivElement '>
223 - why does it extend HTMLDivElement?
224
225 ./base/info_bar_group.html:<polymer-element name='tr-ui-b-info-bar-group' is='HT MLUnknownElement'>
226 - why does it extend HTMLUnknownElement
227
228 ./base/mouse_mode_icon.html:<polymer-element name="tr-ui-b-mouse-mode-icon">
229 - np
230
231 ./base/mouse_mode_selector.html:<polymer-element name="tr-ui-b-mouse-mode-select or">
232 - why __proto__: HTMLDivElement.prototype,
233
234 ./base/resize_sensor.html:<polymer-element name="tr-ui-b-resize-sensor">
235 - np
236
237 ./base/table.html:<polymer-element name="tr-ui-b-table">
238 - np
239 ./base/table.html:<polymer-element name="tr-ui-b-table-header-cell" on-tap="onTa p_">
240 -np
241
242 ./base/table_header_cell.html:<polymer-element name="tr-ui-b-table-header-cell"
243 -np
244
245 ./base/toolbar_button.html:<polymer-element name='tr-ui-b-toolbar-button' noscri pt>
246 -np
247
248 ./base/utils_test.html:<polymer-element name="instantiate-template-polymer-eleme nt-test">
249 -np
250
251 ./extras/chrome/cc/raster_task_view.html:<polymer-element name="tr-ui-e-chrome-c c-raster-task-view">
252 -np
253
254 ./extras/deep_reports/html_results.html:<polymer-element name="tr-ui-e-deep-repo rts-html-results">
255 -np
256
257 ./extras/drive/comment_element.html:<polymer-element name="tr-ui-e-drive-comment -element" attributes="comment">
258 -np
259
260 ./extras/drive/comments_side_panel.html:<polymer-element name='tr-ui-e-drive-com ments-side-panel'
261 - np
262
263 ./extras/rail/ir_verifier_row.html:<polymer-element name="tr-ui-e-rail-ir-verifi er-row">
264 - np
265
266 ./extras/rail/ir_verifier_view.html:<polymer-element name="tr-ui-e-rail-ir-verif ier-view">
267 - np
268
269 ./extras/rail/rail_score_side_panel.html:<polymer-element name='tr-ui-e-rail-rai l-score-side-panel'
270 - np
271
272 ./extras/rail/rail_score_span.html:<polymer-element name="tr-ui-e-rail-rail-scor e-span">
273 - np
274
275 ./extras/side_panel/alerts_side_panel.html:<polymer-element name='tr-ui-e-s-aler ts-side-panel'
276 - np
277
278 ./extras/side_panel/category_summary_side_panel.html:<polymer-element name='tr-u i-e-s-category-summary-side-panel'
279 - np
280
281 ./extras/side_panel/input_latency_side_panel.html:<polymer-element name='tr-ui-e -s-input-latency-side-panel'
282 - np
283
284 ./extras/side_panel/time_summary_side_panel.html:<polymer-element name="tr-ui-e- s-time-summary-side-panel"
285 - np
286
287 ./find_control.html:<polymer-element name="tr-ui-find-control">
288 - np
289
290 ./scripting_control.html:<polymer-element
291 - np
292
293 ./side_panel/side_panel.html:<polymer-element name='tr-ui-side-panel'>
294 - converted to behavior Catapult.tr_ui_side_panel
295
296 ./side_panel/side_panel_container.html:<polymer-element name='tr-ui-side-panel-c ontainer' is='HTMLUnknownElement'>
297 - why is='HTMLUnknownElement'
298
299 ./timeline_track_view.html:<polymer-element name='tr-ui-timeline-track-view'>
300 - np
301
302 ./timeline_view.html:<polymer-element name='tr-ui-timeline-view'>
303 - had domReady
304 - np
305
306 ./timeline_view_help_overlay.html:<polymer-element name="tr-ui-timeline-view-hel p-overlay">
307 - np
308
309 ./timeline_view_metadata_overlay.html:<polymer-element name="tr-ui-timeline-view -metadata-overlay">
310 - np
311
312 ./units/array_of_numbers_span.html:<polymer-element name="tr-ui-u-array-of-numbe rs-span">
313 - np
314
315 ./units/generic_table_view.html:<polymer-element name="tr-ui-u-generic-table-vie w">
316 - np
317
318 ./units/histogram_span.html:<polymer-element name="tr-ui-u-histogram-span">
319 - np
320
321 ./units/preferred_display_unit.html:<polymer-element name="tr-ui-u-preferred-dis play-unit">
322 - np
323
324 ./units/scalar_span.html:<polymer-element name="tr-ui-u-scalar-span">
325 - added couple of methods so tr-ui-u-time-duration-span do not have to subclass
326 -
327
328 ./units/time_duration_span.html:<polymer-element name="tr-ui-u-time-duration-spa n" extends="tr-ui-u-scalar-span">
329 FIXME
330 - moved functionality to tr-ui-u-scalar-span, had to rename all usage
331
332 ./units/time_stamp_span.html:<polymer-element name="tr-ui-u-time-stamp-span" ex tends="tr-ui-u-scalar-span"
333 FIXME
334 - moved functionality to tr-ui-u-scalar-span, had to rename all usage
335
336 ./view_specific_brushing_state.html:<polymer-element name="tr-ui-b-view-specific -brushing-state">
337 - np
338
339 base/unittest/interactive_test_runner.html
340 - FIXME Polymer.whenReady is no longer available
341
342 base/utils.html
343 - replace template.createInstance with document.importNode(el.content);
344
345 base/polymer_utils.html
346 - Polymer.waitingFor is not found
347 - FIXME getPolymerElementsThatSubclass:
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698